OPENEUROPA-2652: Use patch to add language cache tags to selection page. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanoleguskiza
force-pushed
the
OPENEUROPA-2652
branch
2 times, most recently
from
7370cb8 to
781a623
Compare
upchuk
requested changes
Jan 30, 2020
There was a problem hiding this comment.
- I tested the patch and it seems to do the trick. Can I ask why you are adding the
urlcontext? If it has something to do with the current language (what?) there are also language contexts. - Did you identify why the latest version of the module doesn't work? It seems to work in the component but not in EWCMS.
|
I didn't add the url context, it was already there. The only change I did is I added it to the cacheability object as opposed to adding it manually to the render array. |
|
Checked and the latest version of the module doesn't work due to this change: https://git.drupalcode.org/project/language_selection_page/commit/054e891ca34b1e1285b50e31b32dc13378fa582d Will require a bit more investigation that falls outside of the scope of this. But lock the version to 2.3 so it doesn't break with the new release. |
imanoleguskiza
force-pushed
the
OPENEUROPA-2652
branch
from
781a623 to
aa9ed31
Compare
imanoleguskiza
force-pushed
the
OPENEUROPA-2652
branch
from
aa9ed31 to
1082e8d
Compare
upchuk
approved these changes
Jan 30, 2020
nagyad
approved these changes
Feb 3, 2020
upchuk
requested changes
Feb 3, 2020
upchuk
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-2652
Description
The language selection page doesn't use the proper cache tags so it doesn't get invalidated on CRUD operations on languages. This PR adds the required language list tag.
Change log
Commands