OPENEUROPA-2147: Implementation of third approach with local import translations. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
force-pushed
the
OPENEUROPA-2147-3
branch
2 times, most recently
from
1d9e1ca to
ded136e
Compare
sergepavle
force-pushed
the
OPENEUROPA-2147-3
branch
from
ded136e to
948f7f4
Compare
ademarco
requested changes
Aug 21, 2019
sergepavle
force-pushed
the
OPENEUROPA-2147-3
branch
from
8bd1336 to
f9db38b
Compare
sergepavle
force-pushed
the
OPENEUROPA-2147-3
branch
from
f9db38b to
aa11dba
Compare
This was referenced Aug 22, 2019
ademarco
requested changes
Aug 22, 2019
|
I've tested it locally in different scenarios (clean install, update string from code and changes from ui not overridden) and it works well, it's around 1 minute in total. I'll approve after the remaining comments will be addressed. |
sergepavle
force-pushed
the
OPENEUROPA-2147-3
branch
2 times, most recently
from
4f38ca5 to
f619fb1
Compare
ademarco
previously approved these changes
Aug 22, 2019
upchuk
requested changes
Aug 22, 2019
sergepavle
force-pushed
the
OPENEUROPA-2147-3
branch
from
f619fb1 to
7969771
Compare
upchuk
approved these changes
Aug 26, 2019
ademarco
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-2147
Description
[Exec] Done in 15:33
Change log
Commands