OPENEUROPA-1922: Ensure config localization when site is installed from config. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommand to import local translations.
upchuk
force-pushed
the
OPENEUROPA-1922
branch
4 times, most recently
from
ebe6c6b to
3d55d8c
Compare
sergepavle
requested changes
Jun 11, 2019
| * @return array | ||
| * The extensions. | ||
| */ | ||
| protected function getExtensionsToTranslate(): array { |
There was a problem hiding this comment.
Just insteresting. Why we can't use locale_translation_get_projects()?
There was a problem hiding this comment.
Because the point is to get the extensions that reference local translations (or at least specify them in the info file). See what the actual method does and what the docblock says.
sergepavle
approved these changes
Jun 17, 2019
brummbar
approved these changes
Jun 20, 2019
| $this->drupalGet('import-translations'); | ||
| // Wait for the AJAX to complete. This can take a while until the batch | ||
| // process finishes hence the increase in timeout. | ||
| $this->assertSession()->assertWaitOnAjaxRequest(100000); |
There was a problem hiding this comment.
This can be improved so that we won't wait this much. We will handle it in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things are done here: