OPENEUROPA-1794: Bug in the OE Multilingual uninstallation. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademarco
requested changes
Apr 25, 2019
oe_multilingual.install
Outdated
| $setter->setInterfaceSettings([ | ||
| // By default, the URL based negotiation is the highest priority one. | ||
| LanguageNegotiationUrl::METHOD_ID => -19, | ||
| LanguageNegotiationSelected::METHOD_ID => 20, |
There was a problem hiding this comment.
We shouldn't override the language negotiation settings with Drupal's default as the site might have changed it, we should instead load the current language negotiation settings and remove ours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem with uninstalling OE Multilingual. The admin interface language negotiation plugin needs to be removed.
First commit proves the bug. The second one fixes it.