Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENEUROPA-1781: Do not lock source language value to default language. #58

Merged
merged 2 commits into from
Apr 23, 2019

Conversation

dxvargas
Copy link
Member

OPENEUROPA-1781

Description

Put back default behavior, do not lock source language value to default language.

Change log

  • Removed: Some code introduced in PR #29

Copy link
Member

@ademarco ademarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the EWCMS profile's ```config/install/language.content_settings.node.landing_page.yml`` accordingly:

langcode: en
status: true
dependencies:
  config:
    - node.type.landing_page
  module:
    - content_translation
third_party_settings:
  content_translation:
    enabled: true
id: node.landing_page
target_entity_type_id: node
target_bundle: landing_page
default_langcode: site_default
language_alterable: false

@dxvargas
Copy link
Member Author

dxvargas commented Apr 23, 2019

So we need to change to language_alterable: true?
Also here?
modules/ewcms_blocks/config/install/language.content_settings.block_content.content_block.yml

@ademarco
Copy link
Member

@dxvargas yes also that.

@ademarco ademarco merged commit 318c4bf into master Apr 23, 2019
@ademarco ademarco deleted the OPENEUROPA-1781 branch April 23, 2019 15:04
@ademarco
Copy link
Member

I'll now release Multilingual and open a follow up to fix that also on EWCMS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants