Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENEUROPA-1754: Move content language switcher to header. #55

Merged
merged 12 commits into from
Apr 8, 2019

Conversation

imanoleguskiza
Copy link
Member

OPENEUROPA-1754:

Description

Move content language switcher to header.

Change log

  • Added:
  • Changed: Move content language switcher to header.
  • Deprecated:
  • Removed:
  • Fixed:
  • Security:

Commands

[Insert commands here]

tests/Behat/DrupalContext.php Outdated Show resolved Hide resolved
tests/features/content-language-switcher.feature Outdated Show resolved Hide resolved
oe_multilingual.module Show resolved Hide resolved
@voidtek voidtek self-requested a review April 1, 2019 14:29
Copy link
Member

@voidtek voidtek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks.

voidtek
voidtek previously approved these changes Apr 4, 2019
oe_multilingual.services.yml Outdated Show resolved Hide resolved
src/ContentLanguageSwitcherProvider.php Outdated Show resolved Hide resolved
src/Plugin/Block/ContentLanguageBlock.php Outdated Show resolved Hide resolved
src/Plugin/Block/ContentLanguageBlock.php Show resolved Hide resolved
src/Plugin/Block/ContentLanguageBlock.php Show resolved Hide resolved
'#links' => $available_languages,
'#attributes' => [
'class' => [
"language-switcher",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this class here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it was there in the first place ... :(

tests/features/content-language-switcher.feature Outdated Show resolved Hide resolved
tests/features/content-language-switcher.feature Outdated Show resolved Hide resolved
oe_multilingual.module Show resolved Hide resolved
ademarco
ademarco previously approved these changes Apr 8, 2019
@upchuk upchuk merged commit 38ee0b6 into master Apr 8, 2019
@upchuk upchuk deleted the OPENEUROPA-1754 branch April 8, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants