OPENEUROPA-582: Port CI to Drone. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidtek
force-pushed
the
OPENEUROPA-582
branch
11 times, most recently
from
b4ce084 to
aa82efc
Compare
ademarco
reviewed
Jul 12, 2018
composer.json
Outdated
| @@ -63,6 +63,7 @@ | |||
| }, | |||
| "config": { | |||
| "sort-packages": true, | |||
| "preferred-install": "source", | |||
There was a problem hiding this comment.
@voidtek why do we need to set source as preferred method for installation?
dxvargas
previously approved these changes
Jul 16, 2018
dxvargas
approved these changes
Jul 17, 2018
dxvargas
approved these changes
Jul 17, 2018
pfrenssen
reviewed
Jul 17, 2018
| "https://www.drupal.org/project/drupal/issues/2943172": "https://www.drupal.org/files/issues/2018-04-15/2943172-kernel-test-base-2.patch", | ||
| "https://www.drupal.org/project/drupal/issues/2599228": "https://www.drupal.org/files/issues/2599228-31-tests-only.patch" | ||
| "https://www.drupal.org/project/drupal/issues/2943172": "https://www.drupal.org/files/issues/2018-07-05/2943172-kernel-test-base-3.patch", | ||
| "https://www.drupal.org/project/drupal/issues/2599228": "https://www.drupal.org/files/issues/2018-05-17/2599228-51.patch" |
There was a problem hiding this comment.
This is changing patches which can cause errors in other components that depend on oe_multilingual. In case composer-patches encounters two different versions of the same patch it will throw an error. This will happen for example in oe_theme which depends on oe_multilingual.
I think it is best to wait with this until we were able to remove all the patches.
There was a problem hiding this comment.
Since we are going to deal with the patches in a follow up I'm approving this PR.
imanoleguskiza
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-582
Description
Port CI to Drone.
Change log
Commands