EWPP-1907: Update to PHP8. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-1907
branch
8 times, most recently
from
95726a9 to
e261694
Compare
22Alexandra
force-pushed
the
EWPP-1907
branch
from
e261694 to
73c863d
Compare
hernani
requested changes
Jan 24, 2022
22Alexandra
force-pushed
the
EWPP-1907
branch
from
b0948b3 to
0f79ca9
Compare
hernani
previously approved these changes
Jan 24, 2022
yenyasinn
reviewed
Jan 25, 2022
composer.json
Outdated
| "phpunit/phpunit": "^7 || ^8" | ||
| "openeuropa/code-review": "^2.0", | ||
| "openeuropa/task-runner-drupal-project-symlink": "^1.0-beta5", | ||
| "phpunit/phpunit": "^7 || ^8", |
There was a problem hiding this comment.
Not sure, that we should support PHPUnit 7. It's better to provide support for PHPUnit 9.
Suggested change
| "phpunit/phpunit": "^7 || ^8", | |
| "phpspec/prophecy-phpunit": "^1 || ^2", |
yenyasinn
approved these changes
Jan 25, 2022
hernani
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.