Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELA-751: Contextual classes. #348

Open
wants to merge 3 commits into
base: 1.x
Choose a base branch
from
Open

ELA-751: Contextual classes. #348

wants to merge 3 commits into from

Conversation

julien-
Copy link
Contributor

@julien- julien- commented Aug 2, 2023

No description provided.

@julien- julien- changed the title ELA-751: Add somme contextual classes for project builders. ELA-751: Add somme contextual classes. Aug 2, 2023
@julien- julien- changed the title ELA-751: Add somme contextual classes. ELA-751: Contextual classes. Aug 2, 2023
@julien- julien- force-pushed the ELA-751 branch 3 times, most recently from f581a0f to 296d02e Compare August 7, 2023 14:15
brummbar
brummbar requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@brummbar brummbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need more context in order to understand what a PR does.
Also, it misses tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brummbar brummbar brummbar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien- @brummbar