OPENEUROPA-777: Make sure component dependencies are as relaxed as possible. #9
Conversation
… it use the minimal minor version. And also added decimal numer on version to keep the consistency.
aritomelo
force-pushed
the
OPENEUROPA-777
branch
from
1754019 to
11934fe
Compare
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "~5||~6.0", | ||
| "openeuropa/code-review": "~0.3" | ||
| "phpunit/phpunit": "~5.0||~6.0", |
There was a problem hiding this comment.
Let's also update this to remove the double pipe, this is not according to the Composer specification. Let's make it ~5.0|~6.0.
…m version of phpunit and twig on composer.
voidtek
force-pushed
the
OPENEUROPA-777
branch
6 times, most recently
from
f19cdf9 to
e2204bf
Compare
voidtek
force-pushed
the
OPENEUROPA-777
branch
from
e2204bf to
91c2adb
Compare
|
@richardcanoe, I revert your commit according to my comment #9 (comment) |
dxvargas
dismissed stale reviews from richardcanoe and themself
via
423eaf2
.drone.yml
Outdated
| @@ -33,3 +33,6 @@ matrix: | |||
| IMAGE_PHP: | |||
| - fpfis/httpd-php-dev:5.6 | |||
| - fpfis/httpd-php-dev:7.1 | |||
| COMPOSER_BOUNDARY: | |||
| - '--prefer-lowest' | |||
| - '' | |||
There was a problem hiding this comment.
I'm don't like how a command option and an empty string are being used as matrix options. This is taking a shortcut that makes it more difficult to understand.
The original approach that was proposed by Gregory is better: he proposed to set the boundary options to "highest" and "lowest" and limit the builds by using the "when" parameter. This makes it clear what is going on. In addition to this the steps in the pipeline were descriptively named.
See here for an example of how this can be done in a clean way: https://github.com/openeuropa/code-review/blob/d4e105a788835ef851c3816eceffb5c26ba34517/.drone.yml
.editorconfig
Outdated
| [*] | ||
| end_of_line = LF | ||
| indent_style = space | ||
| indent_size = 4 |
There was a problem hiding this comment.
This is setting the indenting to 4 spaces for all the files in the project. But for example I see that the .drone.yml file is using an indent of 2 spaces. This is in conflict with what is being proclaimed here.
I would suggest to take this out of this PR for now, it is out of scope and needs additional work. This can best be handled in a dedicated issue.
|
This is looking good now, but one of my earlier remarks turned out to be incorrect as was pointed out by @dxvargas in one of the sister issues. I suggested to change the "or" clause in the PHPUnit version string from a double pipe to a single pipe, but in fact the double pipe is the preferred symbol, as documented in Versions and constraints - version range. The single pipe is only supported for backwards compatibility reasons. I will make this small correction and approve the PR. |
Set Minimal minor version.
And also added decimal numer to keep the consistency.