Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEL-337: Drupal 9 update. #31

Merged
merged 2 commits into from
Sep 30, 2021
Merged

OEL-337: Drupal 9 update. #31

merged 2 commits into from
Sep 30, 2021

Conversation

escuriola
Copy link
Contributor

OPENEUROPA-337

Description

Fixes to upgrade oe_theme to Drupal 9

Change log

  • Added:
  • Changed: PHP 7.3 required and accept Twig 2.14. Some Twig updates.
  • Deprecated:
  • Removed:
  • Fixed:
  • Security:

Commands

[Insert commands here]

composer.json Outdated
@@ -7,12 +7,12 @@
"prefer-stable": true,
"require": {
"php": ">=7.2",
"twig/twig": "^1.34"
"twig/twig": "^1.34 || ^2.14"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need only latest "twig/twig": "^2.14". I would say it should be "twig/twig": "^1.34 || ^2.7" since version <=2.6 have security issues https://packagist.org/packages/twig/twig.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 1.34 contains security issues, so lowest supported version is 1.38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants