Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card-refactoring): Redone usage of card and layouts of content-banner and listings - OEL-1689 #386

Merged
merged 15 commits into from
Jun 30, 2022

Conversation

tibi2303
Copy link
Collaborator

[skip chromatic]

tibi2303 added 2 commits June 22, 2022 10:49
[skip chromatic]
[skip chromatic]
@tibi2303 tibi2303 changed the title feat(ra)OEL-1689-#default feat(card-refactoring): Redone layouts of cards - OEL-1689 Jun 22, 2022
@github-actions
Copy link

github-actions bot commented Jun 22, 2022

🚀 Deployed on https://preview-386--oelibrary.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 22, 2022 11:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 22, 2022 11:21 Inactive
[skip chromatic]
@github-actions github-actions bot temporarily deployed to pull request June 23, 2022 11:59 Inactive
[skip chromatic]
@tibi2303 tibi2303 changed the title feat(card-refactoring): Redone layouts of cards - OEL-1689 feat(card-refactoring): Redone usage of card and layouts of content-banner and listings - OEL-1689 Jun 23, 2022
[skip chromatic]
@github-actions github-actions bot temporarily deployed to pull request June 23, 2022 12:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 24, 2022 07:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 27, 2022 08:10 Inactive
[skip chromatic]
@github-actions github-actions bot temporarily deployed to pull request June 27, 2022 08:51 Inactive
@@ -1,5 +1,25 @@
@include media-breakpoint-up(lg) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why did you remove this..?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, indeed, it was a conflict not merged properly. thx, revert it

tibi2303 added 2 commits June 28, 2022 10:41
[skip chromatic]
[chromatic]
@github-actions github-actions bot temporarily deployed to pull request June 28, 2022 07:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 29, 2022 11:21 Inactive
tibi2303 added 2 commits June 29, 2022 15:58
[skip chromatic]
[chromatic]
@github-actions github-actions bot temporarily deployed to pull request June 29, 2022 13:11 Inactive
[skip chromatic]
@github-actions github-actions bot temporarily deployed to pull request June 29, 2022 13:22 Inactive
@planctus planctus merged commit 2feb14e into development Jun 30, 2022
@planctus planctus deleted the OEL-1689-#default# branch June 30, 2022 07:03
@github-actions github-actions bot temporarily deployed to pull request June 30, 2022 07:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants