feat(vacancy): Vacancy feature - OEL-1454 #330
Conversation
|
🚀 Deployed on https://preview-330--oelibrary.netlify.app |
| const header = | ||
| layout[`header_${process.env.STORYBOOK_THEME}`] || layout.headerSimple; | ||
|
|
||
| if (isChromatic()) { |
There was a problem hiding this comment.
can you do the same also when the env variable is set..?
There was a problem hiding this comment.
yes, also updated this part
| "version": "0.22.0", | ||
| "description": "OE - BCL Vacancy", | ||
| "publishConfig": { | ||
| "access": "public" |
There was a problem hiding this comment.
does it have to be public this one..?
| badges: ["stable"], | ||
| badgesConfig: { | ||
| stable: { | ||
| title: "v1.1", |
There was a problem hiding this comment.
but we are introducing this feature as new...why is it already 1.1..? :) Wasn't this an internal versioning of the single features.?
There was a problem hiding this comment.
Talked with romain and we could already implement the 1.1 version.
| return expect(renderListing(demoListing)).resolves.toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test("details (closed) renders correctly", () => { |
There was a problem hiding this comment.
guess that this title is wrong..
|
|
||
| export default { | ||
| title: "Features/Vacancy", | ||
| decorators: [withDesign], |
There was a problem hiding this comment.
don't we have withCode also, now..?
There was a problem hiding this comment.
yes, indeed, i added.
| "version": "0.22.0", | ||
| "description": "OE - BCL Vacancy", | ||
| "private": true, | ||
| "repository": { |
There was a problem hiding this comment.
we miss some dependencies here..button, description-list, file, modal, base-templates
There was a problem hiding this comment.
added the dependencies.
| @@ -0,0 +1,2 @@ | |||
| __snapshots__ | |||
No description provided.