Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headers): Added subthemes header - OEL-1437 #328

Merged
merged 6 commits into from
Apr 19, 2022

Conversation

tibi2303
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 12, 2022

🚀 Deployed on https://preview-328--oelibrary.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 13:26 Inactive
@planctus
Copy link
Contributor

planctus commented Apr 13, 2022

It seems all good to me and now the features in ucpkn they show what they are supposed to show, at least regarding hte header, do you know anything about their footer..? Is it really the "neutral" one that we are currently showing..? Do you know anything about it..? :)

For joinup i wonder if we couldn't propose them to put their customisations in BCL, it would be nice to demo the real joinup header and footer, but it's not up to us

There is one story, though, that should also have this applied to, which is "multilingual", there i don't see the ucpkn header.

Ah, since we are not using chromatic on this please sync with development, there is a storybook update, let's avoid messing up the deps.. ;)

Good job!

@github-actions github-actions bot temporarily deployed to pull request April 13, 2022 15:03 Inactive
@tibi2303
Copy link
Collaborator Author

tibi2303 commented Apr 19, 2022

For the multilingual this are the showcases in figma (Neutral / EC / EU) https://www.figma.com/file/NQlGvTiTXZYN8TwY2Ur5EI/BCL-Features?node-id=5356%3A215100

I am not sure it's needed to show the theme header there.

I asked a question on ux channel for the custom footers, waiting for response.
@planctus

@github-actions github-actions bot temporarily deployed to pull request April 19, 2022 13:28 Inactive
@planctus planctus merged commit 31a4ec8 into development Apr 19, 2022
@planctus planctus deleted the OEL-1437-theme-headers branch April 19, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants