Skip to content

Commit

Permalink
chore(pagination): Fixing accessibility (#384)
Browse files Browse the repository at this point in the history 
* feat(links): Visited links revisited - OEL-1737

* feat(links): Removing exclusions for buttons - OEL-1737

* feat(links): Working solution - OEL-1737

* chore(accessibility) Fixing pagination issues - OEL-1737
  • Loading branch information
@planctus
planctus authored Jun 22, 2022
1 parent 1c8f1d8 commit c7ced8a
Show file tree
Hide file tree
Showing 13 changed files with 76 additions and 0 deletions.
20 changes: 20 additions & 0 deletions src/components/bcl-pagination/__snapshots__/pagination.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ exports[`OE - Pagination center renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -29,6 +30,7 @@ exports[`OE - Pagination center renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -72,6 +74,7 @@ exports[`OE - Pagination center renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -82,6 +85,7 @@ exports[`OE - Pagination center renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -112,6 +116,7 @@ exports[`OE - Pagination end renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -128,6 +133,7 @@ exports[`OE - Pagination end renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -171,6 +177,7 @@ exports[`OE - Pagination end renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -181,6 +188,7 @@ exports[`OE - Pagination end renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -211,6 +219,7 @@ exports[`OE - Pagination lg renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -227,6 +236,7 @@ exports[`OE - Pagination lg renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -270,6 +280,7 @@ exports[`OE - Pagination lg renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -280,6 +291,7 @@ exports[`OE - Pagination lg renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -310,6 +322,7 @@ exports[`OE - Pagination renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -326,6 +339,7 @@ exports[`OE - Pagination renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -369,6 +383,7 @@ exports[`OE - Pagination renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -379,6 +394,7 @@ exports[`OE - Pagination renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -409,6 +425,7 @@ exports[`OE - Pagination sm renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -425,6 +442,7 @@ exports[`OE - Pagination sm renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -468,6 +486,7 @@ exports[`OE - Pagination sm renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -478,6 +497,7 @@ exports[`OE - Pagination sm renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down
4 changes: 4 additions & 0 deletions src/compositions/bcl-event/__snapshots__/event.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1523,6 +1523,7 @@ exports[`OE - event listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -1539,6 +1540,7 @@ exports[`OE - event listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -1600,6 +1602,7 @@ exports[`OE - event listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -1610,6 +1613,7 @@ exports[`OE - event listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down
12 changes: 12 additions & 0 deletions src/compositions/bcl-group/__snapshots__/group.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3241,6 +3241,7 @@ exports[`OE - Group listing Content renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -3257,6 +3258,7 @@ exports[`OE - Group listing Content renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -3318,6 +3320,7 @@ exports[`OE - Group listing Content renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -3328,6 +3331,7 @@ exports[`OE - Group listing Content renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -4856,6 +4860,7 @@ exports[`OE - Group listing Member renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -4872,6 +4877,7 @@ exports[`OE - Group listing Member renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -4933,6 +4939,7 @@ exports[`OE - Group listing Member renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -4943,6 +4950,7 @@ exports[`OE - Group listing Member renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -6439,6 +6447,7 @@ exports[`OE - Group listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -6455,6 +6464,7 @@ exports[`OE - Group listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -6516,6 +6526,7 @@ exports[`OE - Group listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -6526,6 +6537,7 @@ exports[`OE - Group listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down
4 changes: 4 additions & 0 deletions src/compositions/bcl-news/__snapshots__/news.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2304,6 +2304,7 @@ exports[`OE - News listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -2320,6 +2321,7 @@ exports[`OE - News listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -2381,6 +2383,7 @@ exports[`OE - News listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -2391,6 +2394,7 @@ exports[`OE - News listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down
4 changes: 4 additions & 0 deletions src/compositions/bcl-person/__snapshots__/person.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2232,6 +2232,7 @@ exports[`OE - Person listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -2248,6 +2249,7 @@ exports[`OE - Person listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -2309,6 +2311,7 @@ exports[`OE - Person listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -2319,6 +2322,7 @@ exports[`OE - Person listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down
4 changes: 4 additions & 0 deletions src/compositions/bcl-procurement/__snapshots__/procurement.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4498,6 +4498,7 @@ exports[`OE - Procurement listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="First page"
class="page-link"
href="/example.html"
>
Expand All @@ -4514,6 +4515,7 @@ exports[`OE - Procurement listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Previous page"
class="page-link"
href="/example.html"
>
Expand Down Expand Up @@ -4575,6 +4577,7 @@ exports[`OE - Procurement listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Next page"
class="page-link"
href="/example.html"
>
Expand All @@ -4585,6 +4588,7 @@ exports[`OE - Procurement listing renders correctly 1`] = `
class="page-item"
>
<a
aria-label="Last page"
class="page-link"
href="/example.html"
>
Expand Down
Loading

1 comment on commit c7ced8a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Deployed on https://dev--oelibrary.netlify.app

Please sign in to comment.