Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

parity: fix db path when migrating to blooms db #8975

Merged
merged 1 commit into from
Jun 28, 2018
Merged

parity: fix db path when migrating to blooms db #8975

merged 1 commit into from
Jun 28, 2018

Conversation

andresilva
Copy link
Contributor

No description provided.

@andresilva andresilva added F2-bug 🐞 The client fails to follow expected behavior. A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jun 25, 2018
@andresilva andresilva requested a review from debris June 25, 2018 12:05
@5chdn 5chdn removed the F2-bug 🐞 The client fails to follow expected behavior. label Jun 25, 2018
@5chdn
Copy link
Contributor

5chdn commented Jun 25, 2018 •
edited
Loading

No F-labels on PRs please 😆

https://wiki.parity.io/Labelling

@5chdn 5chdn added this to the 1.12 milestone Jun 25, 2018
@andresilva
Copy link
Contributor Author

I need to print that and hang it on my wall. 🙈

@dvdplm
Copy link
Collaborator

dvdplm commented Jun 25, 2018

CI failure seems legit?

@andresilva andresilva force-pushed the andre/fix-blooms-db-migration branch from 758992d to 9f2d91e Compare June 25, 2018 13:18
@andresilva
Copy link
Contributor Author

Should be fixed now.

@andresilva
Copy link
Contributor Author

CI failure seems unrelated now:

error[E0465]: multiple rlib candidates for `syntex` found

@dvdplm
Copy link
Collaborator

dvdplm commented Jun 26, 2018

@andresilva seems like the same CI issue I'm seeing on #8973 (which is why I went checking other PRs CI status yesterday!)

@debris debris added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 26, 2018
@debris
Copy link
Collaborator

debris commented Jun 26, 2018

please rebase on latest master

@andresilva andresilva force-pushed the andre/fix-blooms-db-migration branch from 9f2d91e to c186ec6 Compare June 27, 2018 10:52
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Jun 27, 2018
@5chdn 5chdn merged commit 47ff3a9 into master Jun 28, 2018
@5chdn 5chdn deleted the andre/fix-blooms-db-migration branch June 28, 2018 10:24
dvdplm added a commit that referenced this pull request Jul 2, 2018
@dvdplm
Merge branch 'master' into refactor/hashdb-generic
f487a69 
* master:
  Minimal effective gas price in the queue (#8934)
  parity: fix db path when migrating to blooms db (#8975)
  Preserve the current abort behavior (#8995)
  Improve should_replace on NonceAndGasPrice (#8980)
  Tentative fix for missing dependency error (#8973)
ordian added a commit to ordian/parity that referenced this pull request Jul 9, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
d2a67f1 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  parity: fix db path when migrating to blooms db (openethereum#8975)
  Preserve the current abort behavior (openethereum#8995)
  Improve should_replace on NonceAndGasPrice (openethereum#8980)
  Tentative fix for missing dependency error (openethereum#8973)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@debris debris debris approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.0 Ethereum
Development

Successfully merging this pull request may close these issues.
5 participants
@andresilva @5chdn @dvdplm @debris @niklasad1