Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Remove the Keccak C library and use the pure Rust impl #8657

Merged
merged 15 commits into from
May 20, 2018
Merged

Remove the Keccak C library and use the pure Rust impl #8657

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9c65009
Add license and readme
dvdplm May 15, 2018
df0ebc1
Use pure rust implementation
dvdplm May 18, 2018
eb614b0
Bump version to 0.1.1
dvdplm May 15, 2018
c9adf4e
Don't use C, prefer the pure Rust implementation
dvdplm May 16, 2018
7de620a
Add test for `write_keccak`
dvdplm May 16, 2018
66d36d9
Bump version
dvdplm May 16, 2018
ac9a431
Add benchmarks
dvdplm May 16, 2018
3276b00
Add benchmarks
dvdplm May 18, 2018
000d12f
Add keccak_256, keccak_512, keccak_256_unchecked and keccak_512_unche…
dvdplm May 18, 2018
64f6440
Remove failed git merge attempt from external git repo
dvdplm May 18, 2018
5933f02
whitespace
dvdplm May 18, 2018
4db027a
Mark unsafe function unsafe
dvdplm May 18, 2018
8b0db76
Unsafe calls in unsafe block
dvdplm May 18, 2018
aa19995
Document unsafety invariants
dvdplm May 18, 2018
421c922
Revert unintended changes to Cargo.lock
dvdplm May 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ethash/src/keccak.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ pub mod keccak_512 {
pub fn inplace(input: &mut [u8]) {
// This is safe since `sha3_*` uses an internal buffer and copies the result to the output. This
// means that we can reuse the input buffer for both input and output.
hash::keccak_512_unchecked(input.as_mut_ptr(), input.len(), input.as_ptr(), input.len());
unsafe {
hash::keccak_512_unchecked(input.as_mut_ptr(), input.len(), input.as_ptr(), input.len());
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rphmeier should these functions also be pub unsafe …?

Copy link
Contributor

@rphmeier rphmeier May 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. &mut [T] has type-system guarantees to point to valid data. there is no way, using only safe code, to create a &mut T which is invalid. If you did it with unsafe code, then the error would be in that unsafe code and not in this function.

}
}

Expand All @@ -47,6 +49,8 @@ pub mod keccak_256 {
pub fn inplace(input: &mut [u8]) {
// This is safe since `sha3_*` uses an internal buffer and copies the result to the output. This
// means that we can reuse the input buffer for both input and output.
hash::keccak_256_unchecked(input.as_mut_ptr(), input.len(), input.as_ptr(), input.len());
unsafe {
hash::keccak_256_unchecked(input.as_mut_ptr(), input.len(), input.as_ptr(), input.len());
}
}
}