Prometheus metrics #11823
Prometheus metrics #11823
Conversation
| @@ -0,0 +1,1576 @@ | |||
| { | |||
There was a problem hiding this comment.
Are these configs something we really want to ship inside the repo? cc @denisgranha
|
Looks good overall. Consider making an optional feature flag for this. Also needs a clean rebase onto master. |
Co-authored-by: Artem Vorotnikov <[email protected]>
Co-authored-by: Artem Vorotnikov <[email protected]>
Co-authored-by: Artem Vorotnikov <[email protected]>
Co-authored-by: Artem Vorotnikov <[email protected]>
Co-authored-by: Artem Vorotnikov <[email protected]>
| @@ -0,0 +1,705 @@ | |||
| ##################### Grafana Configuration Defaults ##################### | |||
There was a problem hiding this comment.
this file should live wherever devops/deployment things are maintained
adria0
force-pushed
the
adria0/prometheus-tokio-compat
branch
from
e49f538
to
b9b6758
Compare
Co-authored-by: Andronik Ordian <[email protected]>
adria0
force-pushed
the
adria0/prometheus-tokio-compat
branch
2 times, most recently
from
c2200f5
to
16d89fc
Compare
|
|
||
| let state_db = self.state_db.read(); | ||
| prometheus_gauge(r, "statedb_mem_used", "State DB memory used", state_db.mem_used() as i64); | ||
| prometheus_gauge(r, "statedb_cache_size", "State DB cache size", state_db.cache_size() as i64); |
There was a problem hiding this comment.
Yeah consider putting this under a scope { }.
|
@sorpaas Not everyone needs prometheus metrics. Therefore it would be a good idea to make this a cargo feature which we could enable by default. |
|
@vorot93 I honestly think it's not easy to do that. A lot of the prometheus changes require additional parameters to be set. And if we use flag for that I believe it might be really complicated. Always building prometheus might result in slightly larger binary size, but other than that, as long as the service can be disabled runtime, it wouldn't bring any noticeable performance penalty. The prometheus service is also enabled in Substrate by default. |
Implements #11725
asynctokio-runtime 0.1.2with tokio 0.2 backend.PrometheusMetricsimplemented it inClientandEthSyncparity/metrics.rs, metrics be accessed viahttp://...:3000/metrics, only for full client (not implemented for light client)scripts/prometheus, contains grafana/prometheus visualization. Go to the folder and rundocker-compose up..restoration_status(), so renamed.status()to.creation_status().