Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add prometheus metrics #11762

Closed
wants to merge 18 commits into from
Closed

Add prometheus metrics #11762

wants to merge 18 commits into from

Conversation

adria0
Copy link

@adria0 adria0 commented Jun 4, 2020

Implements #11725

  • New trait PrometheusMetrics implemented it in Client and EthSync
  • Hyper server for serve metrics in parity/metrics.rs, metrics be accessed via http://...:3000/metrics, only for full client (not implemented for light client)
  • Command line flags for metrics, disabled by default, port and interface can be configurated
  • Docker-compose for starting the client with metrics in scripts/prometheus, contains grafana/prometheus visualization. Go to the folder and run docker-compose up.
  • New snapshot creation status .restoration_status() , so renamed .status() to .creation_status().

@adria0 adria0 added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Jun 4, 2020
@adria0 adria0 force-pushed the adria0/prometheus branch from 35e7755 to f85bd40 Compare June 5, 2020 05:45
@adria0 adria0 force-pushed the adria0/prometheus branch from d3bce9a to 40b885c Compare June 9, 2020 18:24
@adria0 adria0 force-pushed the adria0/prometheus branch from 2f97eee to 3fdd742 Compare June 21, 2020 15:55
@adria0 adria0 added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jun 21, 2020
@adria0 adria0 marked this pull request as ready for review June 21, 2020 16:18
@adria0 adria0 requested review from ordian, dvdplm and vorot93 June 21, 2020 19:51
@vorot93
Copy link

vorot93 commented Jun 25, 2020

I think we should try hyper 0.13 with paritytech/parity-common#403

@adria0 adria0 force-pushed the adria0/prometheus branch from 817f0d2 to 53cc9ea Compare June 30, 2020 13:31
@adria0
Copy link
Author

adria0 commented Jul 1, 2020

@adria0 adria0 closed this Jul 17, 2020
@adria0 adria0 deleted the adria0/prometheus branch July 18, 2020 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants