Remove old deprecated flags, move light client, updater and private tx flags to deprecated section #11694

vorot93 · 2020-05-09T01:15:58Z

This PR removes pre-2.7 deprecated flags, and moves light client, updater and private tx toggles to their place instead. Also sets updater filter to Never by default and fixes parity mentions in a couple of places.

Also see #11681 and #11682

parity/deprecated.rs

niklasad1 · 2020-05-11T16:27:46Z

parity/cli/mod.rs

-			ARG arg_rpcport: (Option<u16>) = None, or |_| None,
-			"--rpcport=[PORT]",
-			"Equivalent to --jsonrpc-port PORT.",
+			FLAG flag_no_hardcoded_sync: (bool) = false, or |c: &Config| c.parity.as_ref()?.no_hardcoded_sync,


This is light client-related also, should probably have the same comment as --light so it's not forgotten if/when the light client is removed.

Isn't there a sub command that is used to produce the hard coded headers too? Needs deprecating too then?

Do you mean export-hardcoded-sync? Then yes

niklasad1 · 2020-05-11T16:34:47Z

parity/cli/mod.rs

-			ARG arg_rpcapi: (Option<String>) = None, or |_| None,
-			"--rpcapi=[APIS]",
-			"Equivalent to --jsonrpc-apis APIS.",
+			FLAG flag_no_serve_light: (bool) = false, or |c: &Config| c.network.as_ref()?.no_serve_light.clone(),


Same here, see https://github.com/openethereum/openethereum/pull/11694/files#r423164093

I assume the full nodes won't implement PIP after #11681, thus this flag won't do anything

niklasad1 · 2020-05-11T16:41:30Z

parity/cli/mod.rs

@@ -1204,17 +986,6 @@ struct PrivateTransactions {
 #[serde(deny_unknown_fields)]
 struct Ui {


can this be removed?

I believe this is used by signer

Can you elaborate? If it is, and Signer is going to be around still, maybe it's good to add a comment here to that effect?

parity/main.rs

parity/deprecated.rs

niklasad1

Looks good overall but these changes need to be clearly communicated to the users because it might break their configuration and expectations.

…x flags to deprecated section

dvdplm · 2020-05-22T06:53:32Z

parity/deprecated.rs

-	}
+/// Removed flags will go here.
+pub fn find_deprecated(_args: &Args) -> Vec<Deprecated> {
+	Vec::new()


So after this PR there are no deprecated flags at all?

dvdplm · 2020-05-22T06:54:20Z

parity/deprecated.rs

-			Deprecated::Removed("--whisper-pool-size"),
-		]);
-	}
+/// Removed flags will go here.


Suggested change

/// Removed flags will go here.

/// Returns a list of removed or currently deprecated CLI flags.

dvdplm · 2020-05-22T06:54:41Z

parity/main.rs

@@ -49,7 +49,7 @@ use parity_daemonize::AsHandle;
 use parking_lot::{Condvar, Mutex};

 const PLEASE_RESTART_EXIT_CODE: i32 = 69;
-const PARITY_EXECUTABLE_NAME: &str = "parity";
+const CLIENT_EXECUTABLE_NAME: &str = "openethereum";


Maybe just EXECUTABLE_NAME?

dvdplm · 2020-05-22T07:16:17Z

parity/cli/mod.rs

-			ARG arg_rpcport: (Option<u16>) = None, or |_| None,
-			"--rpcport=[PORT]",
-			"Equivalent to --jsonrpc-port PORT.",
+			FLAG flag_no_hardcoded_sync: (bool) = false, or |c: &Config| c.parity.as_ref()?.no_hardcoded_sync,


Isn't there a sub command that is used to produce the hard coded headers too? Needs deprecating too then?

dvdplm · 2020-05-22T07:18:06Z

parity/cli/mod.rs

@@ -1204,17 +986,6 @@ struct PrivateTransactions {
 #[serde(deny_unknown_fields)]
 struct Ui {


Can you elaborate? If it is, and Signer is going to be around still, maybe it's good to add a comment here to that effect?

vorot93 added A0-pleasereview 🤓 Pull request needs code review. B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases. labels May 9, 2020

vorot93 requested review from dvdplm, ordian and niklasad1 May 9, 2020 01:15

vorot93 force-pushed the vorot93/cli-update branch 3 times, most recently from 72f0724 to 525fea6 Compare May 10, 2020 20:43

vorot93 removed the B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases. label May 11, 2020