This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
remove eip-2200-advance transition #11624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok this is good to go. |
ordian
reviewed
Apr 14, 2020
| @@ -396,7 +396,7 @@ fn calculate_eip1283_sstore_gas<Gas: evm::CostType>(schedule: &Schedule, origina | |||
| if current == new { | |||
| // 1. If current value equals new value (this is a no-op), `SSTORE_DIRTY_GAS` | |||
| // (or if not set, `SLOAD_GAS`) is deducted. | |||
| schedule.sstore_dirty_gas.unwrap_or(schedule.sload_gas) | |||
| schedule.sload_gas | |||
There was a problem hiding this comment.
I think the comments need to be updated here and below, it might be easier to just revert #11347
There was a problem hiding this comment.
I don't think we can revert it entirely because we still need the builtins, no?
There was a problem hiding this comment.
Good point, we can revert this commit only openethereum/openethereum@10077a7
There was a problem hiding this comment.
Not everything in that commit is inaccurate. Maybe I'll just manually rewrite the comments in question.
There was a problem hiding this comment.
This still needs to be addressed ^^
ordian
added
the
A5-grumble 🔥
|
Is this still relevant? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context ref #11347 ref #11474