json-tests: Fix compile error

[ackintosh]

I got the compile error when I run the tests:

$ pwd
/Users/akihito1/src/github.com/ackintosh/parity-ethereum/ethcore

$ cargo test --features=json-tests
   Compiling ethcore v1.12.0 (/Users/akihito1/src/github.com/ackintosh/parity-ethereum/ethcore)
error[E0277]: the trait bound `types::transaction::SignedTransaction: std::convert::From<ethjson::transaction::Transaction>` is not satisfied
  --> ethcore/src/json_tests/state.rs:78:83
   |
78 |                     let transaction: SignedTransaction = multitransaction.select(&state.indexes).into();
   |                                                                                                  ^^^^ the trait `std::convert::From<ethjson::transaction::Transaction>` is not implemented for `types::transaction::SignedTransaction`
   |
   = note: required because of the requirements on the impl of `std::convert::Into<types::transaction::SignedTransaction>` for `ethjson::transaction::Transaction`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
error: could not compile `ethcore`.
warning: build failed, waiting for other jobs to finish...
error[E0277]: the trait bound `types::transaction::SignedTransaction: std::convert::From<ethjson::transaction::Transaction>` is not satisfied
  --> ethcore/src/json_tests/state.rs:78:83
   |
78 |                     let transaction: SignedTransaction = multitransaction.select(&state.indexes).into();
   |                                                                                                  ^^^^ the trait `std::convert::From<ethjson::transaction::Transaction>` is not implemented for `types::transaction::SignedTransaction`
   |
   = note: required because of the requirements on the impl of `std::convert::Into<types::transaction::SignedTransaction>` for `ethjson::transaction::Transaction`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
error: could not compile `ethcore`.

To learn more, run the command again with --verbose.

The error is due to the PR that adding cfg to the From trait.
#11335

[parity-cla-bot]

It looks like @ackintosh signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

[dvdplm]

Thank you so much! :)

[niklasad1]

@dvdplm @s3krit

Has this not been detected because we run cargo test --features json-tests --all in the CI?

(I think all default features gets enabled by --all and that's why it has worked in the CI)

[dvdplm]

Has this not been detected because we run cargo test --features json-tests --all in the CI?

Yes, must be that. Cargo features are sneaky.

[dvdplm]

(I think all default features gets enabled by --all and that's why it has worked in the CI)

Hmm, I think it's because features are additive and so if one crate in the tree enables the feature, it's enabled for all.

[ordian]

@ackintosh thanks!

@dvdplm I don't think it warrants a backport though?