Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

When updating the client or when called from RPC, sleep should mean sleep #10814

Merged
merged 1 commit into from
Jul 2, 2019
Merged

When updating the client or when called from RPC, sleep should mean sleep #10814

merged 1 commit into from
Jul 2, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented Jun 28, 2019

Closes #10687

sleep() is called from several places but when called from disable() or through the setMode RPC, we should ignore queue contents and go to sleep.

@dvdplm
When updating the client or when called from RPC, sleep should mean s…
5f428aa 
…leep

Closes #10687

`sleep()` is called from several places but when called from `disable()` or through the `setMode` RPC, we should ignore queue contents and go to sleep.
@dvdplm dvdplm self-assigned this Jun 28, 2019
@dvdplm dvdplm added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Jun 28, 2019
@dvdplm dvdplm requested a review from debris July 2, 2019 07:14
@ordian ordian added this to the 2.6 milestone Jul 2, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. and removed A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Jul 2, 2019
@ordian ordian added B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. B1-patch-beta 🕷🕷 labels Jul 2, 2019
@dvdplm dvdplm merged commit b4af8df into master Jul 2, 2019
@dvdplm dvdplm deleted the dp/fix/force-sleep-when-called-from-rpc branch July 2, 2019 19:26
ordian added a commit that referenced this pull request Jul 3, 2019
@ordian
Merge branch 'master' into ao-txn-propagation-peer-cache
bee05cb 
* master:
  idiomatic changes to PodState (#10834)
  Allow --nat extip:your.host.here.org (#10830)
  When updating the client or when called from RPC, sleep should mean sleep (#10814)
  Remove excessive warning (#10831)
  Fix typo in README.md (#10828)
  ethcore does not use byteorder (#10829)
dvdplm added a commit that referenced this pull request Jul 4, 2019
@dvdplm
Merge branch 'master' into dp/fix/prevent-building-block-on-top-of-sa…
95ec389 
…me-parent

* master:
  refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812)
  Break circular dependency between Client and Engine (part 1) (#10833)
  tests: Relates to #10655: Test instructions for Readme (#10835)
  refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657)
  idiomatic changes to PodState (#10834)
  Allow --nat extip:your.host.here.org (#10830)
  When updating the client or when called from RPC, sleep should mean sleep (#10814)
  Remove excessive warning (#10831)
  Fix typo in README.md (#10828)
  ethcore does not use byteorder (#10829)
  Better logging when backfilling ancient blocks fail (#10796)
  depends: Update wordlist to v1.3 (#10823)
dvdplm added a commit that referenced this pull request Jul 4, 2019
@dvdplm
Merge branch 'master' into ng-fix-fork-choice
26f80c2 
* master:
  refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812)
  Break circular dependency between Client and Engine (part 1) (#10833)
  tests: Relates to #10655: Test instructions for Readme (#10835)
  refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657)
  idiomatic changes to PodState (#10834)
  Allow --nat extip:your.host.here.org (#10830)
  When updating the client or when called from RPC, sleep should mean sleep (#10814)
  Remove excessive warning (#10831)
  Fix typo in README.md (#10828)
  ethcore does not use byteorder (#10829)
  Better logging when backfilling ancient blocks fail (#10796)
  depends: Update wordlist to v1.3 (#10823)
  cargo update -p smallvec (#10822)
  replace memzero with zeroize crate (#10816)
  Don't repeat the logic from Default impl (#10813)
  removed additional_params method (#10818)
  Add Constantinople eips to the dev (instant_seal) config (#10809)
dvdplm added a commit that referenced this pull request Jul 4, 2019
@dvdplm
Merge branch 'master' into luke-whisper-cli-test
cc45ea8 
* master: (21 commits)
  refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812)
  Break circular dependency between Client and Engine (part 1) (#10833)
  tests: Relates to #10655: Test instructions for Readme (#10835)
  refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657)
  idiomatic changes to PodState (#10834)
  Allow --nat extip:your.host.here.org (#10830)
  When updating the client or when called from RPC, sleep should mean sleep (#10814)
  Remove excessive warning (#10831)
  Fix typo in README.md (#10828)
  ethcore does not use byteorder (#10829)
  Better logging when backfilling ancient blocks fail (#10796)
  depends: Update wordlist to v1.3 (#10823)
  cargo update -p smallvec (#10822)
  replace memzero with zeroize crate (#10816)
  Don't repeat the logic from Default impl (#10813)
  removed additional_params method (#10818)
  Add Constantinople eips to the dev (instant_seal) config (#10809)
  removed redundant fmt::Display implementations (#10806)
  revert changes to .gitlab-ci.yml (#10807)
  Add filtering capability to `parity_pendingTransactions` (issue 8269) (#10506)
  ...
s3krit pushed a commit that referenced this pull request Aug 12, 2019
@dvdplm @s3krit
When updating the client or when called from RPC, sleep should mean s…
1c19ed3 
…leep (#10814)

Closes #10687

`sleep()` is called from several places but when called from `disable()` or through the `setMode` RPC, we should ignore queue contents and go to sleep.
@s3krit s3krit mentioned this pull request Aug 12, 2019
Merged
s3krit added a commit that referenced this pull request Aug 12, 2019
@s3krit
V2.5.6 stable (#10961)
ff398fe 
  -  Fix cargo audit (#10921)
  - Add support for Energy Web Foundation's new chains (#10957)
  - Kaspersky AV whitelisting (#10919)
  - Avast whitelist script (#10900)
  - Docker images renaming (#10863)
  - Remove excessive warning (#10831)
  - Allow --nat extip:your.host.here.org (#10830)
  - When updating the client or when called from RPC, sleep should mean sleep (#10814)
  - added new ropsten-bootnode and removed old one (#10794)
  - ethkey no longer uses byteorder (#10786)
  - Do not drop the peer with None difficulty (#10772)
  - docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (#10652)
@s3krit s3krit mentioned this pull request Aug 14, 2019
Merged
s3krit added a commit that referenced this pull request Aug 14, 2019
@s3krit
2.6.1-beta (#10973)
7bfbe41 
  * Add support for Energy Web Foundation's new chains (#10957)                                                                                                                                  
  * Kaspersky AV whitelisting (#10919)                                                                                                                                                           
  * Avast whitelist script (#10900)                                                                                                                                                              
  * Docker images renaming (#10863)                                                                                                                                                              
  * Remove excessive warning (#10831)                                                                                                                                                            
  * Allow --nat extip:your.host.here.org (#10830)                                                                                                                                                
  * When updating the client or when called from RPC, sleep should mean sleep (#10814)                                                                                                           
  * added new ropsten-bootnode and removed old one (#10794)                                                      
  * ethkey no longer uses byteorder (#10786)                                                            
  * docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (#10652)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jam10o-new jam10o-new jam10o-new approved these changes

@ordian ordian ordian approved these changes

@debris debris Awaiting requested review from debris

Assignees

@dvdplm dvdplm

Labels
A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

setMode(offline) results in: Cannot sleep - syncing ongoing
3 participants
@dvdplm @ordian @jam10o-new