This repository has been archived by the owner on May 24, 2022. It is now read-only.
Refactor URLs we allow navigation to #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linked document warns against explicitly opting out from TLS validation. This doesn't require setting a custom handler.
|
Got the following when clicking on the Blockscout:
Other than the feedback button I don't think we have any other link do we? |
Using |
amaury1093
approved these changes
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #547
This PR only takes care of refactoring the checks when the web contents navigates to an URL. No changes made to the resources checks (i.e. images, fetches, etc.).
It would be nice to double-check if all the external links still open.
I couldn't check if the links to blockscout still work on the packaged versions as I'm getting redirected to the accounts list after staying for a few seconds on any other page; also on master. For example, clicking on "New account" and waiting a few seconds brings me back to the accounts list. Can you repro?