This repository has been archived by the owner on May 24, 2022. It is now read-only.
chore: Allow fetching cross-platform parity-ethereum #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelchalon
reviewed
Apr 9, 2019
| if (stderr) throw new Error(stderr); | ||
| return stdout.match(/v\d+\.\d+\.\d+/)[0]; | ||
| }) | ||
| .catch(error => console.warn(error.message)); |
There was a problem hiding this comment.
maybe in the future add a note to explain that we're catching the error so that the process still exits with 0 when fetching&packaging the windows binary on linux (ci) (then, the binary version cannot be checked)
There was a problem hiding this comment.
+1 also remove the annoying "command failed" messages
axelchalon
reviewed
Apr 9, 2019
| @@ -48,6 +57,11 @@ if (foundPath) { | |||
| // Bundled Parity was found, we check if the version matches the minimum requirements | |||
| getBinaryVersion(foundPath) | |||
| .then(version => { | |||
| if (!version) { | |||
There was a problem hiding this comment.
same, in the future it can use some more commenting, otherwise the underlying logic isn't very clear
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On gitlab we build the Windows binary on Linux: we need to fetch the windows parity-ethereum from linux.
yarn fetch-parity --winor--macor--linux