Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

fix: Fix small bugs after hasty merge #498

Merged
merged 6 commits into from
Apr 8, 2019
Merged

fix: Fix small bugs after hasty merge #498

merged 6 commits into from
Apr 8, 2019

Conversation

amaury1093
Copy link
Collaborator

@amaury1093 amaury1093 commented Apr 8, 2019 •
edited
Loading

Fix some bugs I discovered after merging #451.

  • revert bumping @parity/* packages
  • make blockscout link work
  • allows passing --ws-origins to parity-ethereum

To test: Make sure yarn electron and yarn package both work!

TODO

  • I'm having a broken loading icon (the gif one in the modal) in the generated binary (yarn start works good). Fixed.

Tbaut
Tbaut approved these changes Apr 8, 2019
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the AppImage successfully on Linux

axelchalon
axelchalon approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@axelchalon axelchalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packaged & yarn electron work well

@ltfschoen
Copy link
Contributor

Tested .deb on Linux and works well

@Tbaut Tbaut merged commit ee2a222 into master Apr 8, 2019
@Tbaut Tbaut deleted the am-fix-bugs branch April 8, 2019 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@axelchalon axelchalon axelchalon approved these changes

@ltfschoen ltfschoen Awaiting requested review from ltfschoen

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amaury1093 @ltfschoen @axelchalon @Tbaut