Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Use path.join in fetch-latest-parity.js #489

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Use path.join in fetch-latest-parity.js #489

merged 1 commit into from
Apr 2, 2019

Conversation

axelchalon
Copy link
Contributor

continuing #487

Tbaut
Tbaut approved these changes Apr 2, 2019
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly, the previous PR was enough for me to be able to build on windows. It doesn't hurt to do it everywhere though.
LGTM Tested successfully on windows and linux.

@Tbaut Tbaut merged commit 7dce51a into master Apr 2, 2019
@Tbaut Tbaut deleted the ac-pathjoin-bundling branch April 2, 2019 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tbaut Tbaut Tbaut approved these changes

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelchalon @Tbaut