-
Notifications
You must be signed in to change notification settings - Fork 33
feat: Relates to #402. Internationalisation. German Language Support #464
Conversation
…obbepop (native German speaker)
I removed the "goodfirstissue" as this is a label for issues. We should create some proper issues for that. |
@amaurymartiny @Tbaut i've merged latest from 'master' and from 'luke-402-i18n' branches and fixed merge conflicts, an
To switch between languages, just right-click in the Fether window to open the Fether context menu, choose Preferences > Language > English or German. |
i've created a Fether FAQ PR https://github.com/paritytech/wiki/pull/327 that explains:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sorry I've mistakenly merged the |
Or you could change the base of this one in the top-right Edit button on Github |
:) for some reason I thought only Luke could do that, thanks |
Merge latest from Internationalisation Base Support PR feat: Relates to #402. Internationalisation. Base Support #452 (due to fix merge conflicts since 88c9b18)
Update de.json after convert all text in fether-electron i18n config file into i18n. See 88c9b18#diff-e71da345e8fcc8df02de6ee26e679513R43 due to dot point in feat: Relates to #402. Internationalisation. Base Support #452. Not required as discussed with Tbaut
Update de.json after convert all text in fether-react i18n config file into i18n due to dot point in feat: Relates to #402. Internationalisation. Base Support #452 Not required as discussed with Tbaut
Update de.json files with converson of all text in scripts/fetch-latest-parity.js into i18n due to dot point in feat: Relates to #402. Internationalisation. Base Support #452 Not required as discussed with Tbaut
Remove
"downloading": "Downloading Parity Ethereum...",
from packages/fether-react/src/i18n/locales/de.json in German translation PRUpdate packages/fether-react/src/i18n/locales/de.json to it's
validation.
instead ofvalidation.alert
, and replace all occurrencesAdd to packages/fether-react/src/i18n/locales/de.json
validation.valid_tx
, and update occurrence after mergeRemove from packages/fether-react/src/i18n/locales/de.json the whole
validation.throw
sectionAdd the following to packages/fether-react/src/i18n/locales/de.json with German translation:
Remove from packages/fether-react/src/i18n/locales/de.json the whole
health.token_list
key/value sectionPeer review of Fether menu by someone fluent in German (since I just used Google Translate). fether-electron/src/main/app/menu/i18n/locales/de.json. Review completed thanks to @Robbepop
Peer review of the Fether contents by someone fluent in German (since I just used Google Translate). fether-react/src/i18n/locales/de.json Propose the merge and create an issue requesting "proper" translation of this file by an open-source German native language speaker.