Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

feat: Relates to #402. Internationalisation. German Language Support #464

Merged
merged 28 commits into from
Apr 12, 2019

Conversation

ltfschoen
Copy link
Contributor

@ltfschoen ltfschoen commented Mar 17, 2019

        "fetching_chain_id": "Fetching chain ID",
        "fetching_eth_balance": "Fetching Ether balance",
        "fetching_tx_count": "Fetching transaction count for nonce",
  • Add the following to packages/fether-react/src/i18n/locales/de.json with German translation:
  "releases": {
    "new_release_title": "New version available",
    "new_release_description": "{{release_name}} was released!"
  },
  • Remove from packages/fether-react/src/i18n/locales/de.json the whole health.token_list key/value section

  • Peer review of Fether menu by someone fluent in German (since I just used Google Translate). fether-electron/src/main/app/menu/i18n/locales/de.json. Review completed thanks to @Robbepop

  • Peer review of the Fether contents by someone fluent in German (since I just used Google Translate). fether-react/src/i18n/locales/de.json Propose the merge and create an issue requesting "proper" translation of this file by an open-source German native language speaker.

@Tbaut
Copy link
Collaborator

Tbaut commented Mar 19, 2019

I removed the "goodfirstissue" as this is a label for issues. We should create some proper issues for that.

@ltfschoen
Copy link
Contributor Author

@amaurymartiny @Tbaut i've merged latest from 'master' and from 'luke-402-i18n' branches and fixed merge conflicts, an

To switch between languages, just right-click in the Fether window to open the Fether context menu, choose Preferences > Language > English or German.
Then the Fether window will refresh and show it in the other language.

@ltfschoen
Copy link
Contributor Author

i've created a Fether FAQ PR https://github.com/paritytech/wiki/pull/327 that explains:

  • How to switch between languages that Fether supports?
  • How to add support for a new language to Fether?

Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tbaut
Copy link
Collaborator

Tbaut commented Apr 12, 2019

Sorry I've mistakenly merged the luke-402-i18n to master before. Created #510 to merge this one to master now.

@amaury1093
Copy link
Collaborator

Or you could change the base of this one in the top-right Edit button on Github

@Tbaut Tbaut changed the base branch from luke-402-i18n to master April 12, 2019 11:07
@Tbaut
Copy link
Collaborator

Tbaut commented Apr 12, 2019

:) for some reason I thought only Luke could do that, thanks

@Tbaut Tbaut merged commit 21ca5d6 into master Apr 12, 2019
@Tbaut Tbaut deleted the luke-402-german branch April 12, 2019 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants