This repository has been archived by the owner on May 24, 2022. It is now read-only.
fix: Relates to #324. Show link to Blockscout upon confirmed, not the first confirmation #377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To overcome situations when we don't receive any sendStore.confirmations for a long time after it txStatus.confirmed key is set (i.e. situations when sendStore.confirmations jumps from a value of say -1 to a high value which corresponds to a long delay waiting without the user knowing what's going on), we'll make sure we provide a link to the Blockscout transaction as soon as txStatus.confirmed key is set, because at the moment it only shows the link after
confirmations >= 0
, but the value ofconfirmations
may stay at a negative number for a long time.Now what happens is:
Previously it still didn't show a link to Blockscout, because it would still be waiting for
confirmations >= 0
even though the transaction would be available on Blockscout.In this PR we now show the Blockscout link to the transaction as soon it txStatus is confirmed.
In this PR I've added extra padding between the title and the link to Blockscout