Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

fix: Relates to #324. Show link to Blockscout upon confirmed, not the first confirmation #377

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

ltfschoen
Copy link
Contributor

@ltfschoen ltfschoen commented Jan 19, 2019

To overcome situations when we don't receive any sendStore.confirmations for a long time after it txStatus.confirmed key is set (i.e. situations when sendStore.confirmations jumps from a value of say -1 to a high value which corresponds to a long delay waiting without the user knowing what's going on), we'll make sure we provide a link to the Blockscout transaction as soon as txStatus.confirmed key is set, because at the moment it only shows the link after confirmations >= 0, but the value of confirmations may stay at a negative number for a long time.

Now what happens is:

  1. txStatus is signed, then it shows "Sending your transaction..."

screen shot 2019-01-19 at 11 22 02 pm

  1. txStatus.confirmed key is set, but sendStore.confirmations is often a negative number, so:

screen shot 2019-01-19 at 11 29 35 pm

Previously it still didn't show a link to Blockscout, because it would still be waiting for confirmations >= 0 even though the transaction would be available on Blockscout.

In this PR we now show the Blockscout link to the transaction as soon it txStatus is confirmed.

  1. sendStore.confirmations will often jump to a positive number and change to displaying say "Waiting 3/6 confirmations", since the logic in Sent.js is such that the minimum confirmations is set to a constant of 6 before it displays "Transaction confirmed"

screen shot 2019-01-19 at 11 30 05 pm

  1. Finally when minimum confirmations >= 6 it shows "Transaction confirmed", but sometimes sendStore.confirmations may be say 3 when at the Blockscout link it says its already up to say 15 block confirmations!

In this PR I've added extra padding between the title and the link to Blockscout

screen shot 2019-01-20 at 12 01 13 am

@ltfschoen ltfschoen changed the title fix: Fixes #324. Show link to Blockscout upon confirmed, not the first confirmation fix: Relates to #324. Show link to Blockscout upon confirmed, not the first confirmation Jan 19, 2019
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that's makes the UX better without changing much to the code. I don't mind the padding as well 👍

@amaury1093 amaury1093 merged commit 590c5d1 into master Jan 21, 2019
@amaury1093 amaury1093 deleted the luke-324-tx-status branch January 21, 2019 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants