This repository has been archived by the owner on May 24, 2022. It is now read-only.
Accept 11 words legacy recovery phrases for Parity Signer compatibility #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Tbaut
commented
Jan 10, 2019
Tbaut
commented
- closes Accept a 11 or 12 words parity recovery phrase #350
- tested successfully with a recovery phrase generated by Parity Signer
|
I just used the branch from this PR #336, and applied your change in this PR to it. Then I tried to import an account into Fether that I had previously created on Parity Signer (which has a 11 recovery words), and I was able to do so correctly. There were some issues but they need to be addressed in #336 |
ltfschoen
approved these changes
Jan 10, 2019
| @@ -131,7 +131,7 @@ export class CreateAccountStore { | |||
| const words = phrase.split(' '); | |||
| const PARITY_WORDLIST = getParityWordlist(); | |||
| if ( | |||
| words.length < 12 || | |||
| words.length < 11 || | |||
There was a problem hiding this comment.
could we use a constant for this instead of a magic number?
i.e. const MAX_PARITY_SIGNER_RECOVERY_WORDS = 11;
axelchalon
approved these changes
Jan 11, 2019
amaury1093
approved these changes
Jan 11, 2019
amaury1093
approved these changes
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.