This repository has been archived by the owner on May 24, 2022. It is now read-only.
fix: Fixes #285 sed error on macOS #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @ltfschoen signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
amaury1093
reviewed
Dec 13, 2018
| # Refer to comments in ./fixElectronBug.sh | ||
| if [[ $SED_MAC_DIR == *"/usr/bin/sed"* ]] ; | ||
| then | ||
| /usr/bin/sed -i '.bak' "s/$FIND/$REPLACE/g" $FILE |
There was a problem hiding this comment.
A simpler solution would be just to replace sed with /usr/bin/sed. imo PWD and SED_MAC_DIR are both not necessary
amaury1093
approved these changes
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.