Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

WithHealth: Wait 2s before showing not synced (fix #262) #263

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

axelchalon
Copy link
Contributor

No description provided.

@axelchalon axelchalon changed the title Wait 2s before showing not synced (fix #262) WithHealth: Wait 2s before showing not synced (fix #262) Nov 20, 2018
@Tbaut
Copy link
Collaborator

Tbaut commented Nov 21, 2018

Since I couldn't reproduce myself, can you package the .dmg and post it here?

@axelchalon
Copy link
Contributor Author

I don't think it's possible to build the .dmg from Linux with electron-builder

@Tbaut
Copy link
Collaborator

Tbaut commented Nov 23, 2018

For some reason I forgot you were on linux, then let's merge and I'll send the .dmg to Björn for testing

Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Super elegant solution to remove setTimeouts.

Can;t repro neither, but it looks good.

@amaury1093 amaury1093 merged commit e4c6987 into master Nov 23, 2018
@amaury1093 amaury1093 deleted the ac-fix-2s branch November 23, 2018 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants