Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Set CSP in meta tag #516

Closed
amaury1093 opened this issue Apr 29, 2019 · 0 comments · Fixed by #517
Closed

Set CSP in meta tag #516

amaury1093 opened this issue Apr 29, 2019 · 0 comments · Fixed by #517
Labels
F1-security

Comments

@amaury1093
Copy link
Collaborator

Right now, in production mode, we are setting CSP on onHeadersReceived

https://github.com/paritytech/fether/blob/d0ae207176fd28b8e986e01499f749c4e676c40a/packages/fether-electron/src/main/app/methods/setupRequestListeners.js#L40-L53

However, this doesn't actually set the CSPs: https://electronjs.org/docs/tutorial/security#csp-meta-tag.

We need to manually add a <meta> tag in index.html
@pmespresso pmespresso mentioned this issue May 3, 2019
Merged
amaury1093 pushed a commit that referenced this issue May 6, 2019
@pmespresso @amaury1093
#516 Set CSP in Meta tag (#517)
6541e1b 
* feat: set csp meta in index.html for prod

* fix grumbles
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F1-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#516 Set CSP in Meta tag openethereum/fether
1 participant
@amaury1093