Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Window does not resize #408

Closed
ltfschoen opened this issue Feb 8, 2019 · 0 comments
Closed

Window does not resize #408

ltfschoen opened this issue Feb 8, 2019 · 0 comments

Comments

@ltfschoen
Copy link
Contributor

Merging #332 introduced a bug that prevents the window from resizing when you change between pages.

See error message below:

screen shot 2019-02-08 at 10 47 30 pm

I've already investigated the issue and found that it occurs in fether-electron/src/main/app/messages/index.js upon an 'app-resize' event, where the args[0] value may be a float value, and because we use that value to set the new height of the window, it causes an error, because we pass the value as an argument to setContentSize https://electronjs.org/docs/all#winsetcontentsizewidth-height-animate, which only accepts integers arguments for width and height.

amaury1093 added a commit that referenced this issue Feb 8, 2019
fix: Fixes #408 window resize by converting args[0] height to integer for setContentSize
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant