Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Warn users who enter a "To" address of 0x0000000000000000000000000000000000000000 in the "Send Ether" page #248

Closed
ltfschoen opened this issue Nov 10, 2018 · 2 comments

Comments

@ltfschoen
Copy link
Contributor

0x0000000000000000000000000000000000000000 is a valid Ethereum address and the "Address" input field currently considers it valid.
This is correct since it's a proof-of-burn account and normally sending to 0x0000000000000000000000000000000000000000 is used as a mechanism to verifiably burn/destroy Ether or tokens on the assumption that noone has the private key for that address.

But I think we should at least protect users from making mistakes by showing a "warning" tooltip if they enter the value of 0x0000000000000000000000000000000000000000 for the "Amount" incase burning/destroying their Ether wasn't their intention.

Some wallet UIs have been known to not provide sufficient safeguards to protect users by means of input field validation or tooltip warnings. For example sending transactions to 0x0000000000000000000000000000000000000000 by default if a user forgot to enter a value for the recipient address before clicking send.

@Tbaut
Copy link
Collaborator

Tbaut commented Nov 11, 2018

I'd be for marking the 0x0 address as invalid as a quick and good enough solution.

@Tbaut Tbaut added this to the 0.3 milestone Nov 11, 2018
@Tbaut Tbaut added the M7-ui label Nov 11, 2018
amaury1093 added a commit that referenced this issue Dec 14, 2018
fix: Fixes #248. Add validation warning when user tries to send ETH or a token to the zero account
@DrZainAzm
Copy link

• Send 8400 ether to 0xc287cf1f50d5bd56de70bdec1f4103d2b733a6d4 from account 0xed5a231ecc0fa775980ad7b86e49872feacd4c8f.
• Wallet ÐApp handling account 0x0000000000000000000000000000000000000000 requests authorisation to conduct the above through: Message from 0xf1833AeFFb5C625BC81d36037F8f790e562c0c1c to 0x0000000000000000000000000000000000000000 to: Send 8400 ether to 0xc287cf1f50d5bd56de70bdec1f4103d2b733a6d4
• a7bd8721477c6a497cf1b6e09f027808ed6e7bb0bd6766ebfc15e7067ed7093e

[{"constant":true,"inputs":[],"name":"name","outputs":[{"name":"","type":"string"}],"payable":false,"stateMutability":"view","type":"function"},{"constant":false,"inputs":[{"name":"spender","type":"address"},{"name":"value","type":"uint256"}],"name":"approve","outputs":[{"name":"","type":"bool"}],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":false,"inputs":[{"name":"_token","type":"address"}],"name":"reclaimToken","outputs":[],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":true,"inputs":[],"name":"totalSupply","outputs":[{"name":"","type":"uint256"}],"payable":false,"stateMutability":"view","type":"function"},{"constant":false,"inputs":[{"name":"from","type":"address"},{"name":"to","type":"address"},{"name":"value","type":"uint256"}],"name":"transferFrom","outputs":[{"name":"","type":"bool"}],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":false,"inputs":[{"name":"_manager","type":"address"}],"name":"addManager","outputs":[{"name":"success","type":"bool"}],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":true,"inputs":[],"name":"decimals","outputs":[{"name":"","type":"uint8"}],"payable":false,"stateMutability":"view","type":"function"},{"constant":false,"inputs":[{"name":"spender","type":"address"},{"name":"addedValue","type":"uint256"}],"name":"increaseAllowance","outputs":[{"name":"","type":"bool"}],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":false,"inputs":[{"name":"to","type":"address"},{"name":"value","type":"uint256"}],"name":"mint","outputs":[{"name":"","type":"bool"}],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":false,"inputs":[],"name":"claimOwnership","outputs":[],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":true,"inputs":[{"name":"owner","type":"address"}],"name":"balanceOf","outputs":[{"name":"","type":"uint256"}],"payable":false,"stateMutability":"view","type":"function"},{"constant":true,"inputs":[{"name":"","type":"address"}],"name":"listOfManagers","outputs":[{"name":"","type":"bool"}],"payable":false,"stateMutability":"view","type":"function"},{"constant":true,"inputs":[],"name":"owner","outputs":[{"name":"","type":"address"}],"payable":false,"stateMutability":"view","type":"function"},{"constant":true,"inputs":[],"name":"symbol","outputs":[{"name":"","type":"string"}],"payable":false,"stateMutability":"view","type":"function"},{"constant":false,"inputs":[{"name":"spender","type":"address"},{"name":"subtractedValue","type":"uint256"}],"name":"decreaseAllowance","outputs":[{"name":"","type":"bool"}],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":false,"inputs":[{"name":"to","type":"address"},{"name":"value","type":"uint256"}],"name":"transfer","outputs":[{"name":"","type":"bool"}],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":false,"inputs":[{"name":"_manager","type":"address"}],"name":"removeManager","outputs":[{"name":"success","type":"bool"}],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":true,"inputs":[{"name":"owner","type":"address"},{"name":"spender","type":"address"}],"name":"allowance","outputs":[{"name":"","type":"uint256"}],"payable":false,"stateMutability":"view","type":"function"},{"constant":true,"inputs":[],"name":"pendingOwner","outputs":[{"name":"","type":"address"}],"payable":false,"stateMutability":"view","type":"function"},{"constant":false,"inputs":[{"name":"newOwner","type":"address"}],"name":"transferOwnership","outputs":[],"payable":false,"stateMutability":"nonpayable","type":"function"},{"constant":true,"inputs":[{"name":"_manager","type":"address"}],"name":"getInfo","outputs":[{"name":"","type":"bool"}],"payable":false,"stateMutability":"view","type":"function"},{"inputs":[],"payable":false,"stateMutability":"nonpayable","type":"constructor"},{"anonymous":false,"inputs":[{"indexed":true,"name":"previousOwner","type":"address"},{"indexed":true,"name":"newOwner","type":"address"}],"name":"OwnershipTransferred","type":"event"},{"anonymous":false,"inputs":[{"indexed":true,"name":"from","type":"address"},{"indexed":true,"name":"to","type":"address"},{"indexed":false,"name":"value","type":"uint256"}],"name":"Transfer","type":"event"},{"anonymous":false,"inputs":[{"indexed":true,"name":"owner","type":"address"},{"indexed":true,"name":"spender","type":"address"},{"indexed":false,"name":"value","type":"uint256"}],"name":"Approval","type":"event"}]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants
@ltfschoen @Tbaut @DrZainAzm and others