chore(ci): Revert GHA checkout action to v1 #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently an issue we're having with GHA where the wrong commit is built. This appears to be related to issue actions/checkout#237 There is a comment there from 4 days ago (actions/checkout#237 (comment)) where the issue is now acknowledged but it's noted as a complex issue with no definite date for resolution. Others have reverted to v1, so it seems worth trying - especially if the availability of the fix seems to be an unknown (possibly long) time away.
SammyIsConfused
approved these changes
Jul 27, 2020
|
Yup, but keep in mind this is not a fork. This is a direct branch. |
|
Hi there. I just want to react to this statement:
No, it doesn't concern fork more than direct branches. We experienced this issue in a private repository that have not fork at all. It is just random. |
|
Ah! Okay, that's good to know - even happier we've reverted for now. Thanks @jcornaz . 👍 |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
There is currently an issue we're having with GHA where the wrong commit
is built. This appears to be related to issue
actions/checkout#237
There is a comment there from 4 days ago
(actions/checkout#237 (comment))
where the issue is now acknowledged but it's noted as a complex issue
with no definite date for resolution.
Others have reverted to v1, so it seems worth trying - especially if the
availability of the fix seems to be an unknown (possibly long) time
away.
P.S. It seems mainly related to forks - so I think the Renovate PRs are okay.