fix icon URL #8
Open
fix icon URL #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icon is in the main mod_openEQUELLA but icon-red.gif no longer exists, use icon.png instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icon is in the main mod_openEQUELLA pix directory but icon-red.gif no longer exists, this uses icon.png instead (though there is a .gif available, too). Theoretically, the link could still break if the versions of the two plugins don't align, but this makes sense for the current version to at least work together. Really, the search plugin should probably package its own image assets. Seems tricky either way you do it to ensure they always stay in sync.