Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer radio button rather than check box when selecting network #22

Closed
minida28 opened this issue May 20, 2017 · 5 comments
Closed

Prefer radio button rather than check box when selecting network #22

minida28 opened this issue May 20, 2017 · 5 comments

Comments

@minida28
Copy link

I setup a wifi repeater at home and the broadcasted SSID from both routers (same SSSID) are showed up on emonESP network selection screen.

As shown in the below screenshot, I can select both SSIDs. Not sure why, maybe it is because both SSID are identical.

Not a big deal, but it would be better if the UI implements radio button rather than check box, so only one network that can be selected at a time.

image

@minida28 minida28 changed the title Prefer radio button than check button when selecting network Prefer radio button rather than check box when selecting network May 20, 2017
@glynhudson
Copy link
Member

Good idea!

@glynhudson
Copy link
Member

done 👍

@minida28
Copy link
Author

Hi @glynhudson

I've re-tested it, the button type has changed to radio.
But the strange thing is I can still select multiple networks!

image

@minida28
Copy link
Author

I think I have found the issue.
Chrome developer tool throws this error:

Uncaught ReferenceError: networkcheckboxes is not defined
    at HTMLInputElement.networkSelect (config.js:383)

Adding this line just above line 383 on config.js file seems solve the problem:

var networkcheckboxes = document.getElementsByClassName("networkcheckbox");

glynhudson added a commit that referenced this issue May 20, 2017
@glynhudson
Copy link
Member

Thanks, done.

jeremypoulter pushed a commit to jeremypoulter/EmonESP that referenced this issue May 24, 2017
jeremypoulter pushed a commit to jeremypoulter/EmonESP that referenced this issue May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants