-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include repo in upcoming releases #9
Include repo in upcoming releases #9
Conversation
Thanks for the pull request, @mtyaka! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @mtyaka! Is this ready to review? |
@mphilbrick211 Yes, this is ready for review. |
@openedx/enterprise-markhors - hi there! Could someone please review this PR and merge if all looks good? Thanks! |
@mphilbrick211 Will take care of that today. |
@mphilbrick211 Hey, I don't have rights to merge this PR. Maybe @feanil or @ormsbee could do it. |
@mtyaka: I have permissions for administrative reasons (and for things like upgrades), but I'm not one of the people that maintain or contribute to this repo. @navinkarkera is probably the person you want to tag. I'm not clear on what the obligations are for optional plugins in the release. |
@ormsbee @navinkarkera Does not have the access either. |
@sameenfatima78 hi there! Mike O'Connell should be able to merge this, but for some reason I can't tag him. Would you please flag for him? Thanks! |
@mphilbrick211 Yeah Mike left the organization two weeks back. |
@sameenfatima78: To be clear, I can merge this, and I'm willing to do so. But if we're making this a part of the release, I want to know who is going to be responsible for this repo if any issues come up in the coming months. I'd also like to make sure that whoever has that responsibility has the permissions they need to the repo. But at the moment I don't know who that is, or why this is part of the release at all–it doesn't look like it's being installed in edx-platform by default. FYI @bradenmacdonald (this was OpenCraft-authored, right?), @feanil |
@mtyaka @navinkarkera Is this repository currently useful for anyone outside of 2U? If not, we don't need to include it in the release; just add it to the private requirements for edX.org. If yes, please update the README to include a lot more explanation of what this does (with screenshots), how to use it, how to install it, and who authored it and who will be maintaining it. Without proper documentation, it can't be understood nor used, so it's not a good candidate for being in the release. Edit: maybe I misunderstood what "include in the release" means, but in any case the README really needs to be expanded. |
@bradenmacdonald That makes sense. I'll update the readme with purpose and instructions on setting this up with some screenshots. cc: @sameenfatima78 |
Hi @navinkarkera! Any update on this? |
@mphilbrick211 Sorry for the delay, did not get a chance to work on the readme. I'll do it soon and update. |
The PR for updating README and adding AUTHORS file is ready: #10 |
Hi @navinkarkera and @sameenfatima78! Just checking to see if there's an update here? |
@mphilbrick211 Hi, I have opened a Github issue to get merge rights to this repo. I will hopefully be able to merge this PR soon. openedx/axim-engineering#788 |
@mtyaka 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Remove the
maybe: true
placeholder fromopenedx.yaml
file so that this repo will be tagged for upcoming Open edX releases.