BOM-2948: Replace Travis with GitHub CI #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
force-pushed
the
aht/BOM-2948-replace-travis-with-github-actions
branch
from
fc97ce7 to
0b361c6
Compare
estute
reviewed
Nov 29, 2021
| run: pip install -r requirements/ci.txt | ||
|
|
||
| - name: Run Tests | ||
| run: tox |
There was a problem hiding this comment.
In the .travis.yml file, we also ran codecov after the tests. Do we still want to do that?
estute
approved these changes
Nov 29, 2021
|
@estute I went and added the codecov check in a separate commit, but it fails currently. Looking at previous builds, it looks like the I am going to revert my codecov commit and just merge this PR as it was in order to unblock the de-Travisification effort, but heads up that your team may want to install and configure codecov if that's something that you folks see as valuable in this repo. |
codecov was previously run as part of Travis-run CI, so we port it forward to the GitHub Actions CI suite.
This reverts commit 8f967c2f3863736387ff74c9ac35f2c682a5b533. codecov was never configured for this repository. Before we switched to GHA, the TravisCI invocation of `codecov` just failed with `codecov: command not found`. We are punting on codecov for the purposes of getting this repo off of TravisCI, but it may be prudent to add codecov in later.
kdmccormick
force-pushed
the
aht/BOM-2948-replace-travis-with-github-actions
branch
from
e376b9c to
77df11c
Compare
kdmccormick
deleted the
aht/BOM-2948-replace-travis-with-github-actions
branch
|
@kdmccormick thanks for tracking that down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: BOM-2948
Description
TraviswithGitHub CI.Travisbecause this repo hasn't been setup oncodecov.ioyet so skipped the coverage check inGitHub CI.