Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use dbt models for problem datasets #272

Merged
merged 4 commits into from
Aug 7, 2023
Merged

feat: use dbt models for problem datasets #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5e9ee5
feat: use dbt models for problem datasets
SoryRawyer Aug 3, 2023
f92e162
chore: bump aspects-dbt version to v1.3
SoryRawyer Aug 4, 2023
0abf8f6
chore: bump aspects-dbt version
SoryRawyer Aug 7, 2023
2a9074c
chore: resolve merge conflicts
SoryRawyer Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tutoraspects/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@
# For now we are pulling this from github, which should allow maximum
# flexibility for forking, running branches, specific versions, etc.
("DBT_REPOSITORY", "https://github.com/openedx/aspects-dbt"),
("DBT_BRANCH", "v1.2"),
("DBT_BRANCH", "v1.3.1"),
# Path to the dbt project inside the repository
("DBT_REPOSITORY_PATH", "aspects-dbt/aspects"),
# This is a pip compliant list of Python packages to install to run dbt
Expand Down
4 changes: 2 additions & 2 deletions tutoraspects/templates/openedx-assets/assets/datasets/fact_learner_problem_summary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@
warning_text: null
offset: 0
params: null
schema: null
sql: "{% include 'openedx-assets/queries/fact_learner_problem_summary.sql' %}"
schema: {{ DBT_PROFILE_TARGET_DATABASE }}
sql: null
table_name: fact_learner_problem_summary
template_params: null
uuid: 9362354c-1541-43c2-b769-da9818236298
Expand Down
4 changes: 2 additions & 2 deletions tutoraspects/templates/openedx-assets/assets/datasets/fact_problem_responses.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@
warning_text: null
offset: 0
params: null
schema: null
sql: "{% include 'openedx-assets/queries/fact_problem_responses.sql' %}"
schema: {{ DBT_PROFILE_TARGET_DATABASE }}
sql: null
table_name: fact_problem_responses
template_params: null
uuid: 511dd5f1-3925-4e9e-ad8a-a227b5680047
Expand Down
37 changes: 0 additions & 37 deletions tutoraspects/templates/openedx-assets/queries/fact_learner_problem_summary.sql
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions tutoraspects/templates/openedx-assets/queries/fact_problem_responses.sql
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions tutoraspects/templates/openedx-assets/queries/hints_per_success.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
with summary as (
{% include 'openedx-assets/queries/fact_learner_problem_summary.sql' %}
)

select
org,
course_name,
Expand All @@ -10,7 +6,7 @@ select
actor_id,
sum(num_hints_displayed) + sum(num_answers_displayed) as total_hints
from
summary
{{ DBT_PROFILE_TARGET_DATABASE }}.fact_learner_problem_summary
where success = 1
group by
org,
Expand Down