-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate currentlySupportedLangs.jsx dynamically | FC-0012 #389
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
84e832f
to
f6fdead
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 99.16% 99.18% +0.01%
==========================================
Files 74 75 +1
Lines 1674 1713 +39
Branches 413 416 +3
==========================================
+ Hits 1660 1699 +39
Misses 14 14 ☔ View full report in Codecov by Sentry. |
d6fdecb
to
4c52228
Compare
4c52228
to
72f5466
Compare
5af01a9
to
bf4ba4d
Compare
instead of hardcoded `transifex_langs = "ar,fr,es_419,zh_CN"` now it generates the file based on the `atlas pull` result
bf4ba4d
to
7b2596a
Compare
@jristau1984 you are listed as "please inform" for this repo on the spreadsheet. I plan on merging this shortly. |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Changes
Generate the list of languages, instead of hardcoded
transifex_langs = "ar,fr,es_419,zh_CN"
inMakefile
.Now it generates the file based on the
atlas pull
result.This pull request is extracted from the deprecation PR below:
We plan to rebase the other PR once this PR is merged to make it a deprecation-only PR.
Testing instructions
Run the following command:
A sanity check for the generated
src/i18n/messages/currentlySupportedLangs.jsx
can be useful.Refs
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.