-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAR-473] Pass through components from react-responsive and remove custom Responsive components #942
Merged
+93
−393
Merged
[PAR-473] Pass through components from react-responsive and remove custom Responsive components #942
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
49
docs/decisions/0014-removal-of-custom-responsive-components.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
14. Removal of Custom Responsive Components | ||
------------------------------------------- | ||
|
||
Status | ||
------ | ||
|
||
Accepted | ||
|
||
Context | ||
_______ | ||
|
||
Paragon utilizes the `react-responsive <https://www.npmjs.com/package/react-responsive>`_ | ||
NPM package in some components, as well as providing some helper components from | ||
react-responsive. However, often consumers of Paragon require additional responsive | ||
functionality than is offered through Paragon itself and as such resort to installing | ||
react-responsive as a standalone dependency in microfrontends. | ||
|
||
If Paragon instead makes react-responsive a passthrough library, consumers of Paragon will | ||
be able to use react-responsive directly (by importing it from Paragon) rather than needing | ||
to install it separately. This shouldn’t necessarily have any impact on Paragon’s bundle | ||
size since react-bootstrap already ships with Paragon; just not all its functionality is | ||
importable by its consumers. | ||
|
||
Decision | ||
________ | ||
|
||
We will remove the following components: | ||
|
||
- ExtraSmall | ||
- Small | ||
- Medium | ||
- Large | ||
- ExtraLarge | ||
- ExtraExtraLarge | ||
- LargerThanExtraSmall | ||
|
||
We will pass through the following components and functionality from react-responsive: | ||
|
||
- MediaQuery | ||
- useMediaQuery | ||
- Context (as ResponsiveContext) | ||
|
||
Consequences | ||
------------ | ||
|
||
- Consumers of the current `Responsive` components will need to refactor to the passthrough | ||
components from react-responsive. | ||
- Consumers of Paragon will be able to use components from react-responsive directly, without | ||
having to install it separately. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Thanks for the ADR!