Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change base branch for analyze-dependents workflow to next #3368

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Dec 18, 2024

Description

The GitHub Action workflow file that operates on a cron is still trying to create PRs against master and subsequently hanging on the required Netlify deploy preview step that's no longer running for master branch since the release branches were modified.

This PR updates the base branch for the PR generated by the analyze-dependents.yml GitHub Action workflow to be next so the primary docs site is updated.

I'm also removing Prospectus (a private repo for edX.org) from the dependents list.

Deploy Preview

n/a

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for paragon-openedx-v22 ready!

Name Link
🔨 Latest commit d1b3bb0
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v22/deploys/6762e5a15769d600086f1d50
😎 Deploy Preview https://deploy-preview-3368--paragon-openedx-v22.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (92c43c3) to head (d1b3bb0).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.x    #3368      +/-   ##
================================================
- Coverage         93.87%   93.75%   -0.13%     
================================================
  Files               232      237       +5     
  Lines              3937     4053     +116     
  Branches            902      962      +60     
================================================
+ Hits               3696     3800     +104     
- Misses              237      245       +8     
- Partials              4        8       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz force-pushed the ags/update-analyze-deps-workflow-release-22.x branch from bb5f275 to d1b3bb0 Compare December 18, 2024 15:09
@adamstankiewicz adamstankiewicz changed the title fix: change base branch for analyze-dependents workflow fix: change base branch for analyze-dependents workflow to next Dec 18, 2024
@adamstankiewicz adamstankiewicz changed the base branch from release-22.x to release-23.x December 18, 2024 15:09
@adamstankiewicz adamstankiewicz linked an issue Dec 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

analyze-dependents still PRing to master
2 participants