-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: release updates to Chip, SearchField, Pagination, Form.Autosuggest #2995
feat!: release updates to Chip, SearchField, Pagination, Form.Autosuggest #2995
Conversation
…lected values (#2899) This updates the Autosuggest component to provide the consumer with: * The value entered in the textbox by the user * The selected value (as it is displayed in the dropdown) * The id of the selected option This also allows the consumer to determine if the Autosuggest component should be in an error state when * No text has been entered * Text has been entered, but not selection has been made * An external validation check has failed - "customError" The consumer will provide error messages for the appropriate error states BREAKING CHANGE: value of Autosuggest component is now an object instead of a string BREAKING CHANGE: Autosuggest component now uses onChange instead of onSelected BREAKING CHANGE: Autosuggest component now takes in different error messages for value/selection required, and custom errors --------- Co-authored-by: Peter Kulko <[email protected]> Co-authored-by: Kyr <[email protected]> Co-authored-by: Viktor Rusakov <[email protected]>
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2995 +/- ##
==========================================
+ Coverage 93.00% 93.18% +0.18%
==========================================
Files 236 249 +13
Lines 4273 4342 +69
Branches 1033 1036 +3
==========================================
+ Hits 3974 4046 +72
+ Misses 295 292 -3
Partials 4 4 ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 22.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This release contains breaking changes to the following 4 components:
Chip
Pagination
SearchField
Form.Autosuggest
Breaking Changes
Chip
This updates the
Chip
component to reflect the design spec as intended.BREAKING CHANGE: Many of the SCSS variables (i.e., tokens) surrounding
Chip
were removed. Consumers should verify no longer using any of the removed SCSS variables in custom Paragon brands/themes.Pagination
This updates the
Pagination
component to rely on the proper button variants, rather than having all pagination buttons be of the primary variant (even when unselected) with custom styles overriding the default button variant style (e.g., background color).It also refactors the component to be more maintainable moving forward.
BREAKING CHANGE: Many of the SCSS variables (i.e., tokens) surrounding
Pagination
were removed. Consumers should verify no longer using any of the removed SCSS variables in custom Paragon brands/themes.BREAKING CHANGE:
icons
prop now accepts the icon src instead of anIcon
component.Before
After
SearchField
This updates the SearchField component to rely on
IconButton
components for its actions (e.g., reset, submit). It also ensures the external submit button in the dark variant has appropriate hover styles.BREAKING CHANGE:
icons
prop now accepts the icon src instead of anIcon
component.Before
After
Form.Autosuggest
This updates the Autosuggest component to provide the consumer with:
This also allows the consumer to determine if the component should be in an error state when:
The consumer will provide error messages for the appropriate error states.
BREAKING CHANGE:
value
prop ofForm.Autosuggest
is now an object instead of a stringBREAKING CHANGE:
Form.Autosuggest
now usesonChange
instead ofonSelected
BREAKING CHANGE:
Form.Autosuggest
now takes in different error messages for value/selection required, and custom errorsDeploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist