-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: implement i18n in Paragon components and in docs site #1100
Merged
adamstankiewicz
merged 10 commits into
openedx:master
from
raccoongang:vrusakov/implement-i18n
Jun 17, 2022
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0d29c25
feat: add i18n to docs site and to DataTable component
viktorrusakov b766533
chore: update snapshots and fix proptypes
viktorrusakov cf57936
build: add transifex scripts
viktorrusakov 89a1be3
docs: update readme with i18n information
viktorrusakov 1def286
chore: small miscellaneous fixes / improvements
viktorrusakov 2924e11
chore: remove test translations
viktorrusakov 1d4ea68
feat: upgrade to react-intl@5
viktorrusakov a15a66c
test: add IntlProvider wrapper to tests which include i18n components
viktorrusakov 6db5cf2
chore: cleanup after rebase
viktorrusakov 18760fd
chore: move `react-intl` to peer dependencies and fix direction switcher
viktorrusakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ npm-debug.log | |
coverage | ||
jest* | ||
dist | ||
src/i18n/transifex_input.json | ||
|
||
# gatsby files | ||
www/.cache/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[main] | ||
host = https://www.transifex.com | ||
|
||
[edx-platform.paragon] | ||
file_filter = src/i18n/messages/<lang>.json | ||
source_file = src/i18n/transifex_input.json | ||
source_lang = en | ||
type = STRUCTURED_JSON |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,10 +56,10 @@ Consequences | |
ReactDOM.render( | ||
<AppProvider> | ||
<App /> | ||
</IntlProvider>, | ||
</AppProvider>, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. D'oh ;) |
||
document.getElementById('root') | ||
) | ||
) | ||
}) | ||
|
||
initialize({ | ||
// this will add your app's messages as well as Paragon's messages to your app | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a separate project, not
edx-platform
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we will keep this under
edx-platform
for the time being, as it seems most of the projects that consume Paragon are under this project as well. I agree it's a bit odd, though.