-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add the wordpress plugin check action #92
Conversation
Thanks for the pull request, @MaferMazu! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
cb1f828
to
f98acbc
Compare
f98acbc
to
7de2a84
Compare
This looks fantastic. Have you tried this failing? we can make a new PR against this branch that does one of the things that should break this plugin check. |
Here is a PR with |
Great! Thanks for that test PR. |
e2a6317
to
89ef617
Compare
89ef617
to
649ad0b
Compare
@felipemontoya, thanks for the feedback. I refactored the workflows, and the zip version generated is openedx-commerce.zip Note: I added the cd command in the zip process to zip the content but not the folder. This is ready for a re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect. Thanks a lot
Description
This PR adds a GitHub workflow to run WordPress/plugin-check-action.
This PR also refactors the workflows.
The zip version generated with this PR is: openedx-commerce.zip
Testing instructions
The test
WordPress Plugin Check / Plugin Check
passed.Additional information
This test mounts a WordPress environment, installs our plugin using a version similar to our ZIP release, activates the plugin in this new environment, installs the Plugin check (PCP) by WordPress Performance Team and Plugin Review Team, and run the test over our plugin.
Checks tested:
i18n_usage
,code_obfuscation
,direct_db_queries
,enqueued_scripts_in_footer
,enqueued_scripts_size
,enqueued_styles_scope
,file_type
,late_escaping
,localhost
,no_unfiltered_uploads
,performant_wp_query_params
,plugin_header_text_domain
,plugin_readme
,plugin_review_phpcs
,plugin_updater
,trademarks
.Categories tested:
accessibility
,general
,performance
,plugin_repo
,security
.More info in: WordPress/plugin-check-action
Important
This will increase the test execution time by ~ 2 minutes.
Checklist for Merge