Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused scripts and styles #91

Merged
merged 3 commits into from
Sep 3, 2024
Merged

fix: remove unused scripts and styles #91

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b5f8ec
fix: remove unused scripts and styles
MaferMazu Sep 3, 2024
59c3773
fix: stop using an empty enqueued script in all contexts
MaferMazu Sep 3, 2024
c510933
docs: change style by script in doc
MaferMazu Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions admin/views/class-openedx-commerce-enrollment-info-form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,6 @@ public function render_enrollment_info_form( $post ) {
</fieldset>
</div>

<script>

</script>

<?php
}

Expand All @@ -245,9 +241,6 @@ public function render_logs_box( $post ) {
$logs = $this->log_manager->get_logs( $post_id );
?>

<style>

</style>
<div class="openedx_logs_box">
<?php
echo wp_kses(
Expand Down
2 changes: 0 additions & 2 deletions public/class-openedx-commerce-public.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,5 @@ public function enqueue_scripts() {
* between the defined hooks and the functions defined in this
* class.
*/

wp_enqueue_script( $this->plugin_name, plugin_dir_url( __FILE__ ) . 'js/openedx-commerce-public.js', array( 'jquery' ), $this->version, false );
}
}
4 changes: 4 additions & 0 deletions public/js/openedx-commerce-public.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@
* single DOM-ready or window-load handler for a particular page.
* Although scripts in the WordPress core, Plugins and Themes may be
* practising this, we should strive to set a better example in our own work.
*
*
* Note: This file is not queued; you must queue it if you want to add styles here.
* For more information on why we dequeued this file, see https://github.com/openedx/openedx-wordpress-ecommerce/pull/91.
*/

})( jQuery );
Loading