-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add info about tutor-contrib-wordpress plugin #84
Conversation
Thanks for the pull request, @CodeWithEmad! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hello @CodeWithEmad, thanks for your patience. I'll take a look at this PR this week. |
Sorry I couldn't review it before. I will prioritize this in the following days. |
Hello @CodeWithEmad, everything looks good so far. I will test the |
Yes, as I said, the fix and the additional information you added look good. However, I needed clarification about the plugin. In my understanding, the
Are they the two functions the I ask this because when I read
And with the info we are adding to the readme in this PR, I think we need a more accurate description to avoid misunderstood and manage expectations. So, for this PR, I recommend being more direct and clear about what people can do with the plugin. Please let me know what you think. |
Sorry for the late response, @MaferMazu.
Yes, using
You're absolutely right. Having a note, mentioning that "this won't apply a WordPress instance" is necessary. However, now that you mentioned it, we can add a feature to have a WordPress instance in Update: I've added this section to the readme for more clarification. |
2579185
to
fb73b82
Compare
Hi @CodeWithEmad @MaferMazu! Just checking in on this :) |
Hey @mphilbrick211. I've made the changes related to the "Accurate Description" in my repo's readme and made plans for the second part which is deploying a WordPress on local/k8s for the future which comes in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience.
I have one comment left, and then we can merge this 🙌
With the help of tutor-contrib-wordpress plugin, there's no need create oauth application and users. it will take care of those steps.
fb73b82
to
ca94284
Compare
Sorry to add another feedback, but can we maintain the ending new line in the Also, can we update the PR title to use docs as a commit type? Because this is not a feature, it is docs and chore/style, but we can prioritize the docs update. - This is no blocker comment; I can edit this in the merge, but it is for maintaining consistency. Ref: |
You're absolutely right about the end of the file's new line. the formatter removed it and I didn't notice. I'll fix it. |
ca94284
to
921372b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this ✨
This will introduce the
tutor-contrib-wordpress
plugin fortutor
inside documents. also, clean up some tailing whitespace and reformat an XML file.