Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info about tutor-contrib-wordpress plugin #84

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

CodeWithEmad
Copy link
Member

This will introduce the tutor-contrib-wordpress plugin for tutor inside documents. also, clean up some tailing whitespace and reformat an XML file.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 5, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @mafermazu. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@CodeWithEmad CodeWithEmad requested a review from MaferMazu August 5, 2024 15:56
@MaferMazu
Copy link
Contributor

Hello @CodeWithEmad, thanks for your patience. I'll take a look at this PR this week.

@MaferMazu
Copy link
Contributor

Sorry I couldn't review it before. I will prioritize this in the following days.

@MaferMazu
Copy link
Contributor

Hello @CodeWithEmad, everything looks good so far. I will test the tutor-contrib-wordpress, and with that, we can merge this 🙌
Thanks for the contribution.

@MaferMazu
Copy link
Contributor

Yes, as I said, the fix and the additional information you added look good. However, I needed clarification about the plugin.

In my understanding, the tutor-contrib-wordpress allows you to:

Are they the two functions the tutor-contrib-wordpress plugin has? Please correct me if I am wrong.

I ask this because when I read tutor-contrib-wordpress, I expected to have a plugin that would launch a WordPress site when I launched the platform. Something like tutor-contrib-codejail or tutor-notes. And I think the readme description is not so clear with that:

This is a Tutor plugin for integrating the Open edX Commerce WordPress Plugin with your Open edX instance. The plugin allows seamless synchronization and interaction between your WordPress site and the Open edX platform, providing a cohesive e-commerce experience. If you don't know how to install the WordPress plugin, check out this installation guide.

And with the info we are adding to the readme in this PR, I think we need a more accurate description to avoid misunderstood and manage expectations.

So, for this PR, I recommend being more direct and clear about what people can do with the plugin.
And for the plugin, I will open some issues/doubts about it in the plugin repo.

Please let me know what you think.

@CodeWithEmad
Copy link
Member Author

CodeWithEmad commented Oct 6, 2024

Sorry for the late response, @MaferMazu.

Are they the two functions the tutor-contrib-wordpress plugin has?

Yes, using tutor dev|local|k8s do init --limit=wordpress or tutor dev|local|k8s launch after enabling the plugin will create the applications, and afterward, you can run tutor wordpress config to see the data used to create the applications and use them here.

I think we need a more accurate description to avoid misunderstood and manage expectations.

You're absolutely right. Having a note, mentioning that "this won't apply a WordPress instance" is necessary. However, now that you mentioned it, we can add a feature to have a WordPress instance in dev|local|k8s in the future.

Update: I've added this section to the readme for more clarification.

@mphilbrick211
Copy link

Hi @CodeWithEmad @MaferMazu! Just checking in on this :)

@CodeWithEmad
Copy link
Member Author

Hey @mphilbrick211. I've made the changes related to the "Accurate Description" in my repo's readme and made plans for the second part which is deploying a WordPress on local/k8s for the future which comes in a separate PR.

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience.
I have one comment left, and then we can merge this 🙌

docs/source/how-tos/create_an_openedx_app.rst Outdated Show resolved Hide resolved
With the help of tutor-contrib-wordpress plugin, there's no need create oauth application and users. it will take care of those steps.
@MaferMazu
Copy link
Contributor

Sorry to add another feedback, but can we maintain the ending new line in the phpcs.xml file? I added the why in the reference.

Also, can we update the PR title to use docs as a commit type? Because this is not a feature, it is docs and chore/style, but we can prioritize the docs update. - This is no blocker comment; I can edit this in the merge, but it is for maintaining consistency.

Ref:
https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

@CodeWithEmad
Copy link
Member Author

You're absolutely right about the end of the file's new line. the formatter removed it and I didn't notice. I'll fix it.

@MaferMazu MaferMazu changed the title feat: tutor-contrib-wordpress plugin docs: add info about tutor-contrib-wordpress plugin Oct 29, 2024
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ✨

@MaferMazu MaferMazu merged commit 5429bff into openedx:main Oct 29, 2024
5 checks passed
@CodeWithEmad CodeWithEmad deleted the feat/tutor-plugin branch October 29, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants