Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop using an empty enqued style in all contexts #79

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

MaferMazu
Copy link
Contributor

Description

This is a quick fix to avoid loading the openedx-commerce-public.css in all contexts.

I pass the plugin in a Plugin Checker. to check we follow the WordPress standards. And I found this warning:
Screenshot from 2024-06-06 14-58-39

I only removed the queued action because it is not needed. The openedx-commerce-public.css doesn't have styles.

With this PR, the plugin checker responds the following:
Screenshot from 2024-06-06 15-01-03

Testing instructions

Check if everything is alright in our stage. This version is in our stage: https://share.1password.com/s#ywKsPlWEUFR__qx_a_ZyoT1jyd8DUJQUs4ycraieSRg

Checklist for Merge

  • Tested in a remote environment
  • Rebased master/main
  • Squashed commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @MaferMazu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@MaferMazu MaferMazu requested review from feanil and felipemontoya June 6, 2024 14:19
@MaferMazu MaferMazu force-pushed the mfmz/remove-enqueue-style branch from f8e33ca to 8891ec1 Compare June 6, 2024 14:21
felipemontoya
felipemontoya previously approved these changes Jun 6, 2024
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very reasonable. However I think we should leave the note a the css file as well saying that is not enqueued and future devs wanting to add styles should also enqueue the file again.

@MaferMazu MaferMazu force-pushed the mfmz/remove-enqueue-style branch from 06cdadd to eb5829a Compare June 7, 2024 12:17
@MaferMazu
Copy link
Contributor Author

Thanks for the feedback, @felipemontoya. I have already added the note.

@MaferMazu MaferMazu requested a review from felipemontoya June 7, 2024 12:28
@MaferMazu MaferMazu enabled auto-merge (squash) June 7, 2024 12:29
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I think this solves it.

@MaferMazu MaferMazu merged commit bedc8ea into openedx:main Jun 7, 2024
4 checks passed
@openedx-webhooks
Copy link

@MaferMazu 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants